From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751438AbdBMCAC (ORCPT ); Sun, 12 Feb 2017 21:00:02 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:49839 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbdBMCAA (ORCPT ); Sun, 12 Feb 2017 21:00:00 -0500 X-AuditID: b6c32a39-f79c86d000001a4c-66-58a1131dc035 Subject: Re: [PATCH v2 4/6] drm: convert drivers to use of_graph_get_remote_node To: Rob Herring , David Airlie , Daniel Vetter , Sean Paul Cc: Neil Armstrong , Liviu Dudau , dri-devel@lists.freedesktop.org, Tomi Valkeinen , Frank Rowand , Marek Vasut , Kevin Hilman , Chen-Yu Tsai , Krzysztof Kozlowski , Xinliang Liu , Javier Martinez Canillas , Xinwei Kong , Kukjin Kim , Mali DP Maintainers , devicetree@vger.kernel.org, Chen Feng , Jyri Sarha , Carlo Caione , Russell King , Matthias Brugger , Alison Wang , Jingoo Han , Seung-Woo Kim , linux-kernel@vger.kernel.org, Kyungmin Park , Rongrong Zou , Maxime Ripard From: Hoegeun Kwon Message-id: <0de1f9be-f095-eb0e-7f5d-eeb32c8167e5@samsung.com> Date: Mon, 13 Feb 2017 10:59:50 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <20170209190558.4784-5-robh@kernel.org> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02TbUxTZxTHfe5bi1vnpQX3jMVBrvPDSKi95e3RAJuZWe7QD2z6oZkxeAM3 LRltsZcSdctSGbTyLnHZoE5e0kwUy4CCgoQRUozA1LLqnG8pMHVEEEZYRIFFWNvLEr79zjn/ f57zP8kjx5U9shh5nqlQsJj4fIbaTFwZ+kCTsE3VrNMErsSiKt8ohs63thNo0t2Oo5abP+Oo 8ZqPRL8vzlOofnaNQrNzbgxdeFEvQxVlp0hU8+Q5jpYd3Rhaej1AorGxDhm6VTwrQ3f6fqTQ 4E8OAp1/cZNAs/aTABWXJKLLnl9w5K0+hCa+dxLodk0thtb6e2Uo0HELoLoz0xRqb3xIoWXv GIa65r8l0OPpFvKjWM7d4AbcnT/8ODd/v1TGlY9WY9xZm5/gOh5fIrkG5wjBtTwKkNxTjx9w q0M1GHfVGZBxT851yjhX/zTGeVrLKK7n5STJTVQMY1lRXwhpBoHPFSxxginHnJtn0qcz+w5k f5ydnKJhE9hdKJWJM/FGIZ3Zuz8r4ZO8/ODRmLgiPt8abGXxosjszEizmK2FQpzBLBamM4dY VqtmNalqrVarTko8vFubHJQcEQwlvgGqoD76WNtgJ2kDjshyECGHdBKsmvaREm+Fv423UyFW 0r0AXr0RXw42B9mBQdfKs+BAHjb0+eVSvwXA64NthFQEAHSvlYXdKvpzONM9SoYGUfRpAEca JrFQgdPNcmirK8ZDKopOgIuV97AQK+gM2H/JG3YT9A5YtvI0rImmdbD3fiUlaSLh0plxIsQR wTWmeprDe+P0bji1WrrOsbDLPYdLedojoOvGPmntbdAzuN7eCy/6XJTEKjgz3C2T+F3Yuvow vCekKwB8VXwBl4pggmVbx7o7EU5MjuPSY2/BvxcrSekBBTxlV0oSDg41zhAS74GP6row6USd AE5U1RKnQaxzQx7nhgzODRmaAN4KtgoFolEviGxBslrkjaLVpFfnmI0eEP408bt6wXXffi+g 5YB5U2GzN+mUJF8kHjd6AZTjTJQickuzTqnI5Y+fECzmbIs1XxC9IDl441o8JjrHHPyCpsJs NimFTdImsWyqVqNl3laQmlqdktbzhcKXglAgWP73YfKIGBuovivu8L60H7RffpC/CZ/+cOLf VO2fC5kjy0XWr7O6nw1YrzV9d+TwD9V9njeUCb0nF1QrqqNT1piLC1/VG9rOPZjTn9jz6p1/ Sm7b+75JK/3Mj79/bF796dJf7z13xMWrd0YNZni2iJm+xF8zXdGOCuemu2sHZxks5fX2o3WG pbZ75DBDiAaejcctIv8fVaaj9UoEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCKsWRmVeSWpSXmKPExsVy+t9jAV0Z4YURBh9O2Fj0njvJZLFs1XoW iwdr1jNbLD+zjtli/pFzrBZXvr5ns5j55j+bxZu3a5gsVnyZyW7R3dnBatH/+DWzxc/2LUwW P/7uY7U4f34Du8XZpjfsFpd3zWGzOLC0ncVi2ZczLBZv2hoZLZpajC22btrLbHGoL9ri/rRZ LBaX+icyWfzfs4Pd4u6Gs4wWMya/ZLNYP/8Wm8XPQ+eZLDa/b2axePRyOauDvMeaeWsYPS5f u8js8f5GK7tH18k+Jo/ZDRdZPDY8Ws3qMW/WCRaP5bfvsno82XSR0ePf4X4mj52z7rJ7PJ67 kd1j8Z6XTB6bVnWyeWz/9oDV4373caYAkSg3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE 3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZbSc28dWMFO0Yu2BjawNjO2CXYwcHBIC JhK7LnJ0MXICmWISF+6tZwOxhQSWMkr8n17QxcgFZN9nlJj/aSM7SEJYIEBixc23zCAJEYEJ jBKn9/9hhKjayChx9sQ1sAyzwFIOifarK8BmsQnoSnztuc4EYvMK2EnsWX0ILM4ioCrR+esJ M4gtKhAhMf/pKqgaQYkfk++xgNicQOc9276QFcRmFjCT+PLyMJQtL7F5zVvmCYwCs5C0zEJS NgtJ2QJG5lWMEqkFyQXFSem5hnmp5XrFibnFpXnpesn5uZsYwSnsmdQOxoO73A8xCnAwKvHw Lli0IEKINbGsuDL3EKMEB7OSCK8g/8IIId6UxMqq1KL8+KLSnNTiQ4ymQI9MZJYSTc4Hpte8 knhDE3MTc2MDC3NLSxMjJXHextnPwoUE0hNLUrNTUwtSi2D6mDg4pRoYDxyOObisTMwvPH/F AWsps8ZNZ3lXmb1NUCnRupBdmRZvf/Vs3awLfAp8mz0+mN+cMYnd/3je4pnSM5svf9F4uIdd dp7sxMf/5r3ceWXNoYNNX1/N32c35cQS7SeLHeTj+WadPfu09fWO42pZ5uKbTs7auoF78fv3 dwUe66x5NyF7ws0ZCXenVm5UYinOSDTUYi4qTgQAaqAsJncDAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170213015957epcas1p1a4508c749b75f74afda6b1088a4b89df X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzMo7IKs7JuQKS/sgqzsm5A=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTMy9Bc3Npc3RhbnQgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170210014141epcas1p326c6d360ae3ec231265a9626329d86de X-RootMTR: 20170210014141epcas1p326c6d360ae3ec231265a9626329d86de References: <20170209190558.4784-1-robh@kernel.org> <20170209190558.4784-5-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index a0def0be6d65..93ebb12133e1 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -228,29 +228,6 @@ static void mic_set_reg_on(struct exynos_mic *mic, bool enable) > writel(reg, mic->reg + MIC_OP); > } > > -static struct device_node *get_remote_node(struct device_node *from, int reg) > -{ > - struct device_node *endpoint = NULL, *remote_node = NULL; > - > - endpoint = of_graph_get_endpoint_by_regs(from, reg, -1); > - if (!endpoint) { > - DRM_ERROR("mic: Failed to find remote port from %s", > - from->full_name); > - goto exit; > - } > - > - remote_node = of_graph_get_remote_port_parent(endpoint); > - if (!remote_node) { > - DRM_ERROR("mic: Failed to find remote port parent from %s", > - from->full_name); > - goto exit; > - } > - > -exit: > - of_node_put(endpoint); > - return remote_node; > -} > - > static int parse_dt(struct exynos_mic *mic) > { > int ret = 0, i, j; > @@ -262,7 +239,7 @@ static int parse_dt(struct exynos_mic *mic) > * The first node must be for decon and the second one must be for dsi. > */ > for (i = 0, j = 0; i < NUM_ENDPOINTS; i++) { > - remote_node = get_remote_node(mic->dev->of_node, i); > + remote_node = of_graph_get_remote_node(mic->dev->of_node, i, 0); > if (!remote_node) { > ret = -EPIPE; > goto exit; > @@ -279,7 +256,7 @@ static int parse_dt(struct exynos_mic *mic) > break; > case ENDPOINT_DSI_NODE: Dear Rob, I have tested this patch, rebase these patches on samsung soc tree[1] and drm exynos tree[2]. But 4/6 patch can not be applied. Because there is a conflict with the already merged [3] patch. Best Regards, Hoegeun [1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/ (for-next branch) [2] https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/ (exynos_drm_next branch) [3] drm/exynos: mic: Fix parse_dt function (cc2b0225) > /* panel node */ > - remote_node = get_remote_node(remote_node, 1); > + remote_node = of_graph_get_remote_node(remote_node, 1, 0); > if (!remote_node) { > ret = -EPIPE; > goto exit; > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > index ebd5f4fe4c23..18d6570e057d 100644 > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > @@ -247,34 +247,6 @@ static const struct component_master_ops kirin_drm_ops = { > .unbind = kirin_drm_unbind, > }; > >