From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932519AbeARRyA (ORCPT ); Thu, 18 Jan 2018 12:54:00 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56590 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103AbeARRx4 (ORCPT ); Thu, 18 Jan 2018 12:53:56 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180118175354euoutp016e15f9629b58a4fa5cf39c483dac1d61~K_QdiAFDC2584725847euoutp010 X-AuditID: cbfec7f2-f793b6d000003243-b8-5a60df30bd61 Subject: Re: [PATCH] crypto: ux500/hash: Add empty export and import From: Kamil Konieczny To: Herbert Xu Cc: "David S. Miller" , Linus Walleij , Bartlomiej Zolnierkiewicz , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Joakim Bech Message-id: <0ded4dca-e253-5a88-3f23-a7e5764ca2cb@partner.samsung.com> Date: Thu, 18 Jan 2018 18:53:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsWy7djPc7oG9xOiDE7sMbDYOGM9q8Wc8y0s Ft2vZCw+r3rKYjHlz3Imi/v3fjJZXN41h82B3WPLyptMHtsOqHrcubaHzaNvyypGj8+b5AJY o7hsUlJzMstSi/TtErgy5v5dzlowV6Ti/7vvjA2MTQJdjJwcEgImEvPbW5kgbDGJC/fWs3Ux cnEICSxllFh3rIkVwvnMKNE57wYLTMfmX6uYIRLLGCU+TFoC1fKMUeLAvLfMIFXCAi4Sdz+3 MoLYbALmEo+2nwHbISKgI7Hy5WJWEJsZZOzUzvguRg4OXgE3iccbNEFMFgFViXN3jUAqRAUi JLqe7QKr5hUQlPgx+R7YDZwC7hJbX6yGmqIp8eLLJBYIW1yiufUmlC0vsXnNW7A7JQRus0kc +7iUHeIBF4lj/74xQtjCEq+Ob4GKy0h0dhxkgmjoZ5RYfuMUO4QzhVHi+LSr0ECyljh8/CLU aj6JSdumM4NcLSHAK9HRJtTFyA5kekg8kYUodpTY9HwNOESEBGYxStw86jKBUX4WkndmIXlh FpIXZiF5YQEjyypGkdTS4tz01GJjveLE3OLSvHS95PzcTYzABHP63/FPOxi/nrA6xCjAwajE w7thcUKUEGtiWXFl7iFGCQ5mJRHed95AId6UxMqq1KL8+KLSnNTiQ4zSHCxK4ry2UW2RQgLp iSWp2ampBalFMFkmDk6pBsbsw5P0lkxmev09LrRFzWNCnML083NEMlQ65esCt0r8CZDtWZEY FT9f9LuN/Y1EuZmvLmX7NZ4RW6G85+cfuRhuaZEz1oWqVttZb7H8M+9fp/37uOGpE7ExwXOY LqUU7/ROjpw/6+Spz7MqlrR//f/ugYrPx7ur7Z9+eyNuvuLZ1Tszlvb90BVVYinOSDTUYi4q TgQA2vhM8ywDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPLMWRmVeSWpSXmKPExsVy+t/xq7oG9xOiDM7c4LLYOGM9q8Wc8y0s Ft2vZCw+r3rKYjHlz3Imi/v3fjJZXN41h82B3WPLyptMHtsOqHrcubaHzaNvyypGj8+b5AJY o7hsUlJzMstSi/TtErgy5v5dzlowV6Ti/7vvjA2MTQJdjJwcEgImEpt/rWKGsMUkLtxbz9bF yMUhJLCEUeLI8iPMEM4zRon5k3+ygVQJC7hI3P3cyghiswmYSzzafoYJxBYR0JFY+XIxK0gD s8BXRom1O3YxQnTPYZRY8OAqSxcjBwevgJvE4w2aICaLgKrEubtGIL2iAhESTTPnsoLYvAKC Ej8m32MBsTkF3CW2vljNClLOLKAuMWVKLkiYWUBcorn1JguELS+xec1b5gmMgrOQdM9C6JiF pGMWko4FjCyrGEVSS4tz03OLDfWKE3OLS/PS9ZLzczcxAqNh27Gfm3cwXtoYfIhRgINRiYd3 w+KEKCHWxLLiytxDjBIczEoivO+8gUK8KYmVValF+fFFpTmpxYcYpTlYlMR5e/esjhQSSE8s Sc1OTS1ILYLJMnFwSjUwal3d9N+5UeBKjY5Y3yOHXd57ZsvPfe8gohNVfSf8p1VZkO9+md+V K7Mt5xR0JbrwNXmFlJzKne12grMxNe3ZrFbPfH3ra9NY2JKTHdznJv3c+ur5lvaVuuFX1524 +d3Z96LtgRX6k4yfePB+ej+Zc/fJxZoPbhwtvFS4eh2XWeDMX95Xjs6Yr8RSnJFoqMVcVJwI AAcKD/+CAgAA X-CMS-MailID: 20180118175352eucas1p1452827db400236b0627121ca665df80c X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180116163219eucas1p132fafc2db8cb9b3af1a1f22d8bf2fdaf X-RootMTR: 20180116163219eucas1p132fafc2db8cb9b3af1a1f22d8bf2fdaf References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please drop this as I will resend it as part of patchset. On 16.01.2018 17:32, Kamil Konieczny wrote: > Crypto framework will require async hash export/import, so add empty > functions to prevent OOPS. > > Signed-off-by: Kamil Konieczny > --- > drivers/crypto/ux500/hash/hash_core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c > index 9acccad26928..2d0a677bcc76 100644 > --- a/drivers/crypto/ux500/hash/hash_core.c > +++ b/drivers/crypto/ux500/hash/hash_core.c > @@ -1403,6 +1403,16 @@ static int ahash_sha256_digest(struct ahash_request *req) > return ret1 ? ret1 : ret2; > } > > +static int ahash_noimport(struct ahash_request *req, const void *in) > +{ > + return -ENOSYS; > +} > + > +static int ahash_noexport(struct ahash_request *req, void *out) > +{ > + return -ENOSYS; > +} > + > static int hmac_sha1_init(struct ahash_request *req) > { > struct crypto_ahash *tfm = crypto_ahash_reqtfm(req); > @@ -1507,6 +1517,8 @@ static struct hash_algo_template hash_algs[] = { > .update = ahash_update, > .final = ahash_final, > .digest = ahash_sha1_digest, > + .export = ahash_noexport, > + .import = ahash_noimport, > .halg.digestsize = SHA1_DIGEST_SIZE, > .halg.statesize = sizeof(struct hash_ctx), > .halg.base = { > @@ -1529,6 +1541,8 @@ static struct hash_algo_template hash_algs[] = { > .update = ahash_update, > .final = ahash_final, > .digest = ahash_sha256_digest, > + .export = ahash_noexport, > + .import = ahash_noimport, > .halg.digestsize = SHA256_DIGEST_SIZE, > .halg.statesize = sizeof(struct hash_ctx), > .halg.base = { > @@ -1553,6 +1567,8 @@ static struct hash_algo_template hash_algs[] = { > .final = ahash_final, > .digest = hmac_sha1_digest, > .setkey = hmac_sha1_setkey, > + .export = ahash_noexport, > + .import = ahash_noimport, > .halg.digestsize = SHA1_DIGEST_SIZE, > .halg.statesize = sizeof(struct hash_ctx), > .halg.base = { > @@ -1577,6 +1593,8 @@ static struct hash_algo_template hash_algs[] = { > .final = ahash_final, > .digest = hmac_sha256_digest, > .setkey = hmac_sha256_setkey, > + .export = ahash_noexport, > + .import = ahash_noimport, > .halg.digestsize = SHA256_DIGEST_SIZE, > .halg.statesize = sizeof(struct hash_ctx), > .halg.base = { > -- Best regards, Kamil Konieczny Samsung R&D Institute Poland