From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932174AbcHIIkB (ORCPT ); Tue, 9 Aug 2016 04:40:01 -0400 Received: from www381.your-server.de ([78.46.137.84]:40889 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752549AbcHIIj5 (ORCPT ); Tue, 9 Aug 2016 04:39:57 -0400 Subject: Re: [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst To: Shawn Lin , Vinod Koul References: <1470365602-32586-1-git-send-email-shawn.lin@rock-chips.com> <1470365602-32586-2-git-send-email-shawn.lin@rock-chips.com> <20160805033410.GJ9681@localhost> Cc: Rob Herring , Huibin Hong , Xing Zheng , devicetree@vger.kernel.org, dianders@chromium.org, briannorris@chromium.org, Caesar Wang , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org From: Lars-Peter Clausen Message-ID: <0df0ab4f-0032-6487-2c30-b1ccd7d9ae62@metafoo.de> Date: Tue, 9 Aug 2016 10:39:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2016 09:25 AM, Shawn Lin wrote: > Hi Vinod, > > 在 2016/8/5 11:34, Vinod Koul 写道: >> On Fri, Aug 05, 2016 at 10:53:20AM +0800, Shawn Lin wrote: >>> This patch adds the "arm,pl330-periph-burst" for arm-pl330 to >>> support busrt mode. >> >> why should this be DT property. Only reason I can think of if some hw >> versions support this and some won't. > > yes, if we want to support burst mode, both of the master(pl330) and > client(several peripherals) should implement it, otherwise it will > be broken when enabling. As you said, it is up to the consumer peripheral whether it supports BURST, SINGLE or both. So this is a per client property, but you specify this as a a global property on the producer side.