From: Neil Armstrong <neil.armstrong@linaro.org>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
dri-devel@lists.freedesktop.org
Cc: Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Marek Vasut <marex@denx.de>,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: Re: [PATCH] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock
Date: Mon, 14 Aug 2023 14:38:51 +0200 [thread overview]
Message-ID: <0df7954c-6520-43bb-9246-c4a5a40b202b@linaro.org> (raw)
In-Reply-To: <20230804151010.834990-1-luca.ceresoli@bootlin.com>
On 04/08/2023 17:10, Luca Ceresoli wrote:
> This panel has been implemented in commit 225213f24c79 ("drm/panel-simple:
> Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical
> one mentioned on the documentation to avoid flickering on the unit
> tested. Testing on a different unit shows that the panel actually works
> with the intended 70.93 MHz clock and even lower frequencies so the
> flickering is likely caused either by a defective unit or by other
> different components such as the bridge.
>
> Fixes: 225213f24c79 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry")
This is the wrong sha, it should be eae7488814b5
Neil
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 56854f78441e..ec3a73bbfe30 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2379,7 +2379,7 @@ static const struct panel_desc innolux_g121x1_l03 = {
> };
>
> static const struct display_timing innolux_g156hce_l01_timings = {
> - .pixelclock = { 120000000, 144000000, 150000000 },
> + .pixelclock = { 120000000, 141860000, 150000000 },
> .hactive = { 1920, 1920, 1920 },
> .hfront_porch = { 80, 90, 100 },
> .hback_porch = { 80, 90, 100 },
next prev parent reply other threads:[~2023-08-14 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 15:10 Luca Ceresoli
2023-08-05 16:46 ` Marek Vasut
2023-08-14 12:38 ` Neil Armstrong [this message]
2023-08-14 13:39 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0df7954c-6520-43bb-9246-c4a5a40b202b@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=marex@denx.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=sam@ravnborg.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®