From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757825AbcLQDJc (ORCPT ); Fri, 16 Dec 2016 22:09:32 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44054 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753895AbcLQDJb (ORCPT ); Fri, 16 Dec 2016 22:09:31 -0500 Subject: Re: [GIT PULL] KVM fixes for 4.10 merge window To: Linus Torvalds , Paolo Bonzini References: <1481907450-11741-1-git-send-email-pbonzini@redhat.com> Cc: Linux Kernel Mailing List , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , KVM list From: Pan Xinhui Date: Sat, 17 Dec 2016 11:09:16 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16121703-0004-0000-0000-00000504A7DC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16121703-0005-0000-0000-0000128BE843 Message-Id: <0df8ceac-deeb-d3c2-630c-30f84d363873@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-17_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1612170055 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/12/17 03:42, Linus Torvalds 写道: > On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini wrote: >> >> git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus > > This piece-of-shit branch has obviously never been even compile-tested: > > arch/x86/kernel/kvm.c: In function ‘__kvm_vcpu_is_preempted’: > arch/x86/kernel/kvm.c:596:14: error: ‘struct kvm_steal_time’ has no > member named ‘preempted’ > hi, Linus oh, my bad also. I introduce this struct member and use it in same patch. Better to separate tem into two patches. I make one fix patch below. sorry again. Hi, Paolo I have known where is th problem, I think if we can set this ->preempted later after preempted_enable() or just introduce something like write_guest_nosleep (per cpu memory section in guest, so there is no page_fault or any other cannot sleep problems)? thanks xinhui ----------------- From d4fa3ea0b8b6f3e5ff511604a4a6665d1cbb74c3 Mon Sep 17 00:00:00 2001 From: Pan Xinhui Date: Sat, 17 Dec 2016 02:56:33 -0500 Subject: [PATCH] kvm: fix compile issue we revert commit 0b9f6c4615c993d2b552e0d2bd1ade49b56e5beb which calls sleep function while preempt_disable on host part. But we remove struct kvm_steal_time::preempted too. This casues compile problem as both guest and host code use it. Fix it by adding struct kvm_steal_time::preempted back. Signed-off-by: Pan Xinhui --- arch/x86/include/uapi/asm/kvm_para.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/uapi/asm/kvm_para.h b/arch/x86/include/uapi/asm/kvm_para.h index 94dc8ca..1421a65 100644 --- a/arch/x86/include/uapi/asm/kvm_para.h +++ b/arch/x86/include/uapi/asm/kvm_para.h @@ -45,7 +45,9 @@ struct kvm_steal_time { __u64 steal; __u32 version; __u32 flags; - __u32 pad[12]; + __u8 preempted; + __u8 u8_pad[3]; + __u32 pad[11]; }; #define KVM_STEAL_ALIGNMENT_BITS 5 -- 2.4.11 > where commit b94c3698b4b0 ("Revert "x86/kvm: Support the vCPU > preemption check"") removed the "preempted" field from struct > kvm_steal_time, but you left this in place: > > __visible bool __kvm_vcpu_is_preempted(int cpu) > { > struct kvm_steal_time *src = &per_cpu(steal_time, cpu); > > return !!src->preempted; > } > > And no, that is not a merge artifact in my tree (although that > function did come in from Ingo). That compile failure comes from your > very own branch. > > Am I upset? You bet I am. Get your act together. You can't just > randomly revert things without checking the end result. > > Linus >