From: "luobin (L)" <luobin9@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <luoxianjun@huawei.com>,
<yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>,
<chiqijun@huawei.com>
Subject: Re: [PATCH net-next v1 1/2] hinic: add generating mailbox random index support
Date: Fri, 31 Jul 2020 08:56:35 +0800 [thread overview]
Message-ID: <0dfc0fd6-8ab2-5ba3-98e7-bbd875e03106@huawei.com> (raw)
In-Reply-To: <20200730092502.4582ac4e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2020/7/31 0:25, Jakub Kicinski wrote:
> On Thu, 30 Jul 2020 16:37:15 +0800 Luo bin wrote:
>> +bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func *func_to_func,
>> + u8 *header)
>
> This set seems to add new W=1 C=1 warnings:
>
> drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:572:6: warning: no previous prototype for ‘check_vf_mbox_random_id’ [-Wmissing-prototypes]
> 572 | bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func *func_to_func,
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:1352:28: warning: symbol 'hw_cmd_support_vf' was not declared. Should it be static?
> .
>
Will fix. Thanks for your review.
next prev parent reply other threads:[~2020-07-31 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 8:37 [PATCH net-next v1 0/2] hinic: mailbox channel enhancement Luo bin
2020-07-30 8:37 ` [PATCH net-next v1 1/2] hinic: add generating mailbox random index support Luo bin
2020-07-30 16:25 ` Jakub Kicinski
2020-07-31 0:56 ` luobin (L) [this message]
2020-07-30 8:37 ` [PATCH net-next v1 2/2] hinic: add check for mailbox msg from VF Luo bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dfc0fd6-8ab2-5ba3-98e7-bbd875e03106@huawei.com \
--to=luobin9@huawei.com \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®