From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 322BF3D88E4 for ; Thu, 19 Mar 2026 14:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773931535; cv=none; b=mE3JF7goopmgIu0lFNb88R8aKfu6R4mmN6LSEEWWT1hTrvcidx9m/LP5cYwK4XCyxvSHa42holhVL6Svm0P8wLyo4DEYY4j5u585U60aCYbVr1qxV2nWzulFkrR7Neqv9v3ZBLHlepDeVgm3eT7MIpj4Ara2KQqaP9h06hjpnjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773931535; c=relaxed/simple; bh=Mzcg9iGhNsu/y2fOj+RRyQYTdXyNml9qSUT/osKkUgc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xkv9Yu0y6DgByVkKSPyXNY/cUeJ2H+dq6SiRmdhs7y1M0b4PK6HLq23FxIJtrWFHcO147/+MIiLy1JVLIn0KS2BtE79Nd4hFD6vx/KHrU8x8fmCowXun+HuYs+MCj6bm5Jf9UDwwJmIDVZWtHMOuUeFKfDiwSxApK0201JVfg1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K/Ew7Usg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jpdPwgLx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K/Ew7Usg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jpdPwgLx" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J74ALW1027821 for ; Thu, 19 Mar 2026 14:45:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XY5v6F8rPGscn76B3hyt9Ef051HgBM0NA8ksEqCL9Wg=; b=K/Ew7UsgX3do3O2X q91lxMJxq5fSVm2oZVPYnR0uySRGOBJRRFSWxIn40tvadiwo3WvFDDLqMWGo65FE E8EuKXwOWo57x9CDRNyu36oBeHxskMrcwzVk1OH+444747kW03++HSWktNu9m5uw zBJQ7CCVzjiPbWRRaK6On0UDXbbN8HRPvWqW5W+Hz7z+28BxZ65aU5ApgM04TIoR 212lxl08bADseUWRXLaCsAIDEZw6ChWkpR3rV8PcOR3FtONmz+rxZwvtjcTArjzd A2hhwTyy7i8MaGa/K2q+Rt9dU4SxQ23hORHnu14FHhiTEjA+S98pIrouFp5xEyml 70JGEQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0032kpxp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 14:45:28 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50947db2e97so7559541cf.3 for ; Thu, 19 Mar 2026 07:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773931528; x=1774536328; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XY5v6F8rPGscn76B3hyt9Ef051HgBM0NA8ksEqCL9Wg=; b=jpdPwgLxQu/GVpN11XUEwIPVCO/HbfBY5DcmkfJELfyHi2DmgyHwRUBcvmWburcHjR y/o6ERldMxtY++ooim+mo+X9pMko8bHyLpWyQ3ovf/ILZNc4Y39XB0akZKrNjYpvybni 4TlFHp/c7sYzdN9pANuZRdqzg+ZX8IUHvnObjb/e82ZSKSb5lFEC+u3lueZxpfDm1Shk EkRgiYGQqyGZunP74cYoojgORkVPd7iGX4bW01maAL0JgiJHLRWzzIBL3le2LwzTbukq mG9F3Hu8Nz2SBSSGozBvuDKbiACrMDeX4GcMRLZq24VMgxjQMNQUOyLjaTm+PnsfR+QQ yJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773931528; x=1774536328; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XY5v6F8rPGscn76B3hyt9Ef051HgBM0NA8ksEqCL9Wg=; b=fkgenBIVZ3LlALjid/QOMr5xs/ZHKKz1wKfMjYmvGtzQ+LRmtrFU2E/VxVPYH2eM9E mkFeagCfP9hqP6hQGvkW5DO0xF60B+WU3/2wDoMuKJs4IPm26QRAdzFZivZlgOQldDtj 0ZlnAxPzceLRIFk9JBYlksRRoq2e/J6WuLeotKOEZWwqt4EiDHnzEV5j8Je3SNknCDSy Zvr/F4WgoiLvL2SyoiYCBNd7Ye2c9c6L+0U+Sg6ne7iDBkikdrJCTgR4PAma0j/u1XEa ZPq6UTTrU3vVrM8RXCinGARC4vdYS7Qb/62WQHoQfT4FknUTw7DJgGf3a/8oDZABiG9m QG1w== X-Forwarded-Encrypted: i=1; AJvYcCUEZGyS6LBLMCWtpgMCg/uHcGX3dS/xabuT7C/F9hyDAqNB4jtBjGRSBXLDHDwZVz9ZbXTfdIW5ziSYrS8=@vger.kernel.org X-Gm-Message-State: AOJu0YyCPRhQqtUNuDpefU4veYUFpbHm+AFtcP+/bmFQrH6ZKenrYLwm c6SoyMGRjvRpmo0hpITcXvTxq6pi1OqKCRNVcjjlwbfxkHU/UfPqe/RkHLzoDHJyHoizicB53nV k+iXGr2oefB57uNTQBZePpLtWJxuH7Kt7mC9+vOFJDvb59WiTqVeitKuqQovg0hlN548= X-Gm-Gg: ATEYQzwLyZaG+7CvyLZuHPliP+DgJFcj1EoyYDvJgpH0/pLWyDo9CdNDdxZaRPuLaxi OGEqRKlTgTzeQYxcRlYlFMqg733h/ulioZlmCMOlDqxE8ovNQI/iK98+YSwKuPiy7WScJZmA/SS M0tKF+x4MPdMcf6p24fJrVA/vZ/1P6Hdjs5On4j3ymuiaemat1hbHQtWlpqO4MnqFBdwfGg/Gv9 CITsrLJqGkqEdlUhYPaZcfoDvQb8d9kgFWBkXn+rxQ5gOeHK/lTL+Zg2OHuidU+qKlnkyUhoLLh wdfAJU8XB6q6TuYVM6zV+o0QoO4UTKvotiBPnyLAP4dl4acq72AjyEpmKgVdxh0jR6fUBDNPhxD 64YtDOhqCi1z3uJs3J0WINZXBemmrN+BKvkeXLLkh/jqPpz1iMutcjZtwiz2pOlXcyT7lJbl3UR oYfPE= X-Received: by 2002:a05:622a:58e:b0:509:47e2:9df3 with SMTP id d75a77b69052e-50b147532d2mr81034091cf.1.1773931527922; Thu, 19 Mar 2026 07:45:27 -0700 (PDT) X-Received: by 2002:a05:622a:58e:b0:509:47e2:9df3 with SMTP id d75a77b69052e-50b147532d2mr81033441cf.1.1773931527300; Thu, 19 Mar 2026 07:45:27 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f13e989bsm472548266b.11.2026.03.19.07.45.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 07:45:26 -0700 (PDT) Message-ID: <0dfed5a0-1c07-4e7d-bca4-8183e44c3ada@oss.qualcomm.com> Date: Thu, 19 Mar 2026 15:45:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Enable USB OTG on functional Type-C ports To: Dmitry Baryshkov , Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-topic-x13s_otg-v1-1-cb2e4a08e25d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: eVkNqFhBF-pBYqC37CYmo_eRsWrXLQLz X-Proofpoint-GUID: eVkNqFhBF-pBYqC37CYmo_eRsWrXLQLz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDExNiBTYWx0ZWRfX344ja1o64/2J TTS82Pk3RLzsXzfCgNwT1bgLkT3f4GHV0cqAq6rrecb5CLGya5bwNzXgHZ3LvUyoRgEQYpS58Pu UVHEPZmjz6ZpBdLPwyXlE5ThMDz0ewQKcziLF1PCcNbBCCBB7uMYYjCVmB4brSHtBucyKGQfPpq n1/Loblf6+r0RRGd2UMMGaFaebvmdtYzkgSslL90ZzoPlD/F3V8wuuBPd5Cj3Zo9ThxiIuwuS2R zDPUK5Upaiy+VX0igCKcLv4g3IOdwzn+24sj/wTuW2MFuOo3dR59zSfwtToomAFWemXWu9+S47x RjkiTyhYqjBJM94lSGKgOJGXVWiNNxfmqWj8BJAPl+G6pmMt8cO6AUkjFWXQ0g6fyD5qVlI9ZgT muGxVYs+QgwYBDv2wGVJyyqe+gqSq5qSFkuDjUIOJW5Z8Ge68zFBQje+LLQplK7tyN/gliHPImS s5A2w+MVZsT/gvW1lfA== X-Authority-Analysis: v=2.4 cv=WO9yn3sR c=1 sm=1 tr=0 ts=69bc0c08 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=xFAtMjX05kTKXHXDGPwA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-19_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190116 On 3/13/26 3:37 PM, Dmitry Baryshkov wrote: > On Fri, Mar 13, 2026 at 03:08:03PM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> The two non-multiport USB controllers present on the platform are >> role-switch capable, so mark them as such. They need no additional >> plumbing, as tested on the X13s. >> >> Enable OTG for all devices featuring a data-role provider in one fell >> swoop to prevent hitting the edge case where UCSI code would time out >> trying to get a reference to a struct usb_role_switch, which wouldn't >> be registered if dr_mode was set to anything other than (the default) >> OTG. >> >> Signed-off-by: Konrad Dybcio >> --- >> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 8 -------- >> arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 8 -------- >> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 -------- >> arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts | 8 -------- >> arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts | 8 -------- >> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++ >> 6 files changed, 4 insertions(+), 40 deletions(-) >> > > Reviewed-by: Dmitry Baryshkov Unfortunately it seems like that while it works, it makes the x13s crash upon resume It also crashes there if we flatten the DT node and I'm hoping the solution to that will fix both, but we have to hold it for now Konrad