From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E327243392; Sun, 9 Feb 2025 12:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739102659; cv=none; b=LlfNDkb69MPlYXKQMDlHdAhQunA7T2w3ThqTQF5+fCWXRCsRTA94ZT7BWpl0W7NVggAssrHRW3sDHLSipF4t9eEjGrbOJuWIE+EPfSuyoE3GmwavkF9h3fqsXQiIhzFxTAfUh4SlpCDACNX+uqsUObuYeMZm8y1Txws6EcQwPeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739102659; c=relaxed/simple; bh=nVatTDg1gq3SMA/MyMcJwleDPob1LiXsCZ0nPfzw1Jw=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=q0jA2/dPIScXokda4yz8koTP7Sk6jtMumd/oZ7dFOEzpM8wPzEvkpyKA5CQlHene5VDaNjlSJ5LOvgzoPw+Q6q0PglG9o8WYVc6fxeVXhhI2rt7TIWFzonkOP5xREkltWnn2t3rg246UAJYXki44Of74X9ttebfnt1ACl7kyl5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=PTq1967v; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="PTq1967v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1739102642; x=1739707442; i=markus.elfring@web.de; bh=siVsz7hJRGZRS0yW9KitiZuTjbYFxTt0vaSDpbIwgc8=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=PTq1967v55YwXS566KvT/XLjTdxxQC5OeBrNXKHyuUqtFi9ou9c5uR61s3ExX3Ib aWBL1NBwiWNwu+oDHsj2cFk2GzMT1Axco6wYQa55zDtjGi+EieB66OnBGksRSm2ZT DwuaBku5MuQjgjXq66DoMHflXkxGDS2Y4abNCvCN5sXBFrVMB9+rI2cb85zX5FPQZ RieMYmOINc3I2rjkY/VFdChSIKzSkG7cJX+gB/1uKm8f15TpcqNIR1zhGukh1JnSL QBFOMK2h6uboDZoUKV1iAGwYlJGrqqqgkmEMsyxTigMZ4lXcDf6AQpEA63h5DfOV7 1fPu91+2Iu3olT8bOw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.70.5]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MuFD5-1tOb9j0Y17-013lYl; Sun, 09 Feb 2025 13:04:02 +0100 Message-ID: <0e014581-bb98-43c8-8170-2556ac974657@web.de> Date: Sun, 9 Feb 2025 13:04:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Ethan Carter Edwards , kernel-hardening@lists.openwall.com, linux-hardening@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" Cc: LKML , Daniel Lezcano References: Subject: Re: [PATCH v3] thermal/debugfs: change kzalloc to kcalloc Content-Language: en-GB From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:aYUPO2AWp5BBv3zQ1GB5Wvbgu8NHsMKZgI2Sbrbw9I5ep/mY+3G LVK9E4AQlw0TYlON89sz7c4sMPBh7JJuTzEodJcJzY5Bre4MMmqrCe/cks5HEQxoILradxz ZKgm8nQo9oezHcy+RQqoKoX1/WUjI5xXs0x4Nqw9IsjU1JUFJUYkFRYCSCUf2en03f4I/yb qWoRblFIyon+NPXVcRVSA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:R1iwWSyHSvI=;cF+W21hEJHhKaxZnaZ9vTnAnQSn fF9VtRFP4vH7uroHKw/XAJ5FXsy3HBS9a1T+xUkUhb+eyagjw6KF/44OhNF5ipu3yejaH/0ab EtOhninv/xG/i4Ey0HmlQhkNeiZhHeRxFDeBVG+gwSZ7PUcQlW/M0o4hT4N19uqC4FjWpTWBK 6IN9nTuOLP81KyJgGCch5pmVB6djFRFy6oxApF9/rDyKqZ0jwWtkxv0Mo5/iGj0DVe2Xwhx77 XTqEqNhbmO/HqjXlaEh4/XKAo4LmkTIDQAFRZkMzvLP3vlVqFYeDwjYb6Tgzaay5AMp/DRI3J S6KuJjYbZ5bebrv5W7sxMdBp/ZL3ir824oOl76ekkQi9AxbzEfq3HzFa8Daud7BoFXEWp4xzL enJ9AA8iDiFF+ICMNFSxog41F2KSgs/lycSEAQI+xh84qqQPzGZojPubL6kGgnw32UjD+Zgz6 gun2mLEhlN29BzxwRYDT22bNGgIQY7c62Ma3O50QATEpDvJi154FdcbcinBBhDl6dTq3ZKVsx pfs8iZbi2mLL+XTU+ZSef9guX9UhTxTx3dFAbYUGjZM5Ht9x6acYV1hpnQtdjjNDnt8jyF1qJ 7ZRKGyASI99LXvp/MF0YyhqxzL0dxhQbyaWs8GdTyAXvG524tAgqHoApFQS1uxUGytQbyBfbW TilldQ2TU6BCG2BIC5YNWSqv60eC5ejMkwK9afrlUcZACG0Wa36tRGRJkdAuneXoadYpnrCCM KDpnRbszfiO2hImTdXf0v1ZCrLecY7mEVCCjst8cEiYxVFW19apvz9SYdLfEtfN4k0k6TFX48 e6O8T5QFIbWcNVYJ1ztrKAgSMapeuYddTuozLaKt1JdoJcdDizJAWBugp7Xg8YMCGweCEatRb YgccJpmz+qetRCuhWjU1MuTaJrgEDlb2mnBkgDOcTkz7IHbzjqeiY1lbtpCwkcngDlPTKXh14 2piiOUZuw2wpzGto1XQO2916LXp2we+/yplOLgvx66JtXpTewbVJ06ZEiS4bhtwHf8ymjY/0C gh3Fqez7kY7XTN2e6gjNWHHQwznAg6rRMvPYWR6OkQBjXMLxHB1I6tIz/gKtA6hAmQZUVW9GY MD8UJvYSE8Yn8zWaSYFJmIHcmdJ72VXIqEevBctXaxIcpM/Nmdq90pkOEPOnGIDvwl5Raneha VyLPHhWJ/6sl4f8302L0M2CX9bqYU1l/ZOQCFfpVrEMU3bYDGh8hNzZBnx1sCrC9XfTr9OX2w 5mzwWn65P3ppa06O52QgdyqOEyOmy35/Pt88xDdvFNbrkLt/DinEOCEtNH7CanL+cNL56F+Ng 6M9R+1PRy8VYMBvUPpHtB8uooqr5LPl5wUXM0avFp8/ikqQr9nbIL3D6watpf6/zgxBwd5eJf /BEv594QKJM21LZRtGkcIQLKxKt96969gs/i5+7w70IC3REiTNezNYuPGcWrktRmGhWMR3PWU AZ9q2mw== > We are replacing any instances of kzalloc(size * count, ...) with > kcalloc(count, size, ...) due to risk of overflow [1]. * See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv6.13#n94 * Would you like to improve the summary phrase another bit? =E2=80=A6 > +++ b/drivers/thermal/thermal_debugfs.c > @@ -876,7 +876,7 @@ void thermal_debug_tz_add(struct thermal_zone_device= *tz) > > tz_dbg->tz =3D tz; > > - tz_dbg->trips_crossed =3D kzalloc(sizeof(int) * tz->num_trips, GFP_KER= NEL); > + tz_dbg->trips_crossed =3D kcalloc(tz->num_trips, sizeof(int), GFP_KERN= EL); =E2=80=A6 See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/coding-style.rst?h=3Dv6.13#n941 Regards, Markus