From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
vincent.knecht@mailoo.org, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
"André Apitzsch" <git@apitzsch.eu>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Vladimir Zapolskiy" <vladimir.zapolskiy@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss
Date: Thu, 26 Jun 2025 12:28:56 +0200 [thread overview]
Message-ID: <0e030c09-0a89-4883-b958-85ddd6831407@kernel.org> (raw)
In-Reply-To: <e928a7c5-56d5-4f2b-b667-bdbefb506d1f@linaro.org>
On 26/06/2025 12:19, Bryan O'Donoghue wrote:
> On 26/06/2025 11:00, Krzysztof Kozlowski wrote:
>>> + reg-names:
>>> + items:
>>> + - const: csi_clk_mux
>> No, I already provided arguments in two lengthy discussions - this is
>> not sorted by name.
>>
>> Keep the same order as in previous device, so msm8916 for example. Or
>> any other, but listen to some requests to sort it by some arbitrary rule
>> which was never communicated by DT maintainers.
>
> I don't think if you look through the history that you can find a
> consistent rule that was used to arrange the registers.
>
> So we are trying to have a consistent way of doing that. Thats why the
> last number of additions have been sort by name, because it seemed to be
> the most consistent.
Why are we discussing it again? You asked me the same here:
https://lore.kernel.org/all/8f11c99b-f3ca-4501-aec4-0795643fc3a9@kernel.org/
and I already said - not sorting by name. You take the same order as
previous.
If you ever want to sort by name, answer to yourself:
NO. Take the same order as other existing device.
If you ever want to sort by value, answer to yourself:
NO.
You both came with some new, invented rules of sorting, applied it, and
now you claim that "existing devices were sorted like that". What? NO!
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-26 10:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 9:33 [PATCH v5 0/4] CAMSS support for MSM8939 Vincent Knecht via B4 Relay
2025-06-13 9:33 ` [PATCH v5 1/4] media: qcom: camss: vfe: Add VBIF setting support Vincent Knecht via B4 Relay
2025-06-13 9:33 ` [PATCH v5 2/4] media: qcom: camss: Add support for MSM8939 Vincent Knecht via B4 Relay
2025-06-26 10:56 ` Vladimir Zapolskiy
2025-06-13 9:33 ` [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss Vincent Knecht via B4 Relay
2025-06-13 11:42 ` Bryan O'Donoghue
2025-06-13 16:38 ` Vladimir Zapolskiy
2025-06-26 10:00 ` Krzysztof Kozlowski
2025-06-26 10:19 ` Bryan O'Donoghue
2025-06-26 10:28 ` Krzysztof Kozlowski [this message]
2025-06-26 10:48 ` Bryan O'Donoghue
2025-06-26 11:17 ` Vladimir Zapolskiy
2025-06-26 11:41 ` Bryan O'Donoghue
2025-06-26 10:02 ` Krzysztof Kozlowski
2025-06-26 11:17 ` Bryan O'Donoghue
2025-06-13 9:33 ` [PATCH v5 4/4] arm64: dts: qcom: msm8939: Add camss and cci Vincent Knecht via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e030c09-0a89-4883-b958-85ddd6831407@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vincent.knecht@mailoo.org \
--cc=vladimir.zapolskiy@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®