From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Aleksandrs Vinarskis <alex@vinarskis.com>,
Hans de Goede <hansg@kernel.org>, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Daniel Thompson <danielt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property
Date: Mon, 8 Sep 2025 09:20:00 +0200 [thread overview]
Message-ID: <0e030e7d-0a1a-4a00-ba18-ed26107d07fa@oss.qualcomm.com> (raw)
In-Reply-To: <20250908-leds-v3-2-5944dc400668@vinarskis.com>
On 9/8/25 1:18 AM, Aleksandrs Vinarskis wrote:
> A number of existing schemas use 'leds' property to provide
> phandle-array of LED(s) to the consumer. Additionally, with the
> upcoming privacy-led support in device-tree, v4l2 subnode could be a
> LED consumer, meaning that all camera sensors should support 'leds'
> and 'led-names' property via common 'video-interface-devices.yaml'.
>
> To avoid dublication, commonize 'leds' property from existing schemas
> to newly introduced 'led-consumer.yaml'.
>
> Signed-off-by: Aleksandrs Vinarskis <alex@vinarskis.com>
> ---
[...]
>
> + leds:
> + minItems: 1
> + maxItems: 1
My brain compiler suggests this will throw a warning (minItems should
be redundant in this case)
> +
> + led-names:
> + enum:
> + - privacy-led
Nit: "privacy" makes more sense without the suffix, as we inherently
know this is supposed to be an LED
Konrad
next prev parent reply other threads:[~2025-09-08 7:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 23:18 [PATCH v3 0/4] leds: privacy-led support for devicetree Aleksandrs Vinarskis
2025-09-07 23:18 ` [PATCH v3 1/4] dt-bindings: leds: add generic LED consumer documentation Aleksandrs Vinarskis
2025-09-08 14:15 ` Rob Herring (Arm)
2025-09-08 15:43 ` Aleksandrs Vinarskis
2025-09-09 7:07 ` Krzysztof Kozlowski
2025-09-09 16:57 ` Aleksandrs Vinarskis
2025-09-09 20:39 ` Hans de Goede
2025-09-10 8:35 ` Konrad Dybcio
2025-09-10 9:22 ` Aleksandrs Vinarskis
2025-09-07 23:18 ` [PATCH v3 2/4] dt-bindings: leds: commonize leds property Aleksandrs Vinarskis
2025-09-08 7:20 ` Konrad Dybcio [this message]
2025-09-08 7:33 ` Hans de Goede
2025-09-08 7:36 ` Konrad Dybcio
2025-09-08 10:47 ` Aleksandrs Vinarskis
2025-09-08 22:22 ` Rob Herring
2025-09-09 9:06 ` Hans de Goede
2025-09-09 9:21 ` Hans de Goede
2025-09-09 9:28 ` Aleksandrs Vinarskis
2025-09-09 14:48 ` Hans de Goede
2025-09-07 23:18 ` [PATCH v3 3/4] leds: led-class: Add devicetree support to led_get() Aleksandrs Vinarskis
2025-09-07 23:18 ` [PATCH v3 4/4] arm64: dts: qcom: sc8280xp-x13s: enable camera privacy indicator Aleksandrs Vinarskis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e030e7d-0a1a-4a00-ba18-ed26107d07fa@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=alex@vinarskis.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=danielt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hansg@kernel.org \
--cc=jacopo@jmondi.org \
--cc=jingoohan1@gmail.com \
--cc=jjhiblot@traphandler.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®