mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Stanner <phasta@mailbox.org>
To: "Christian König" <christian.koenig@amd.com>,
	"Philipp Stanner" <phasta@kernel.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Gary Guo" <gary@garyguo.net>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	"Yunxiang Li" <Yunxiang.Li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] dma-buf/dma-fence: Ensure correct ordering in dma_fence_timestamp()
Date: Fri, 20 Nov 2026 14:23:36 +0100	[thread overview]
Message-ID: <0e037df8633ca4b4f898d9d29be76bd569709eca.camel@mailbox.org> (raw)
In-Reply-To: <1505a605-a5ba-4fed-bc91-89177faee4a0@amd.com>

On Fri, 2026-11-20 at 10:33 +0100, Christian König wrote:
> On 11/19/26 14:18, Philipp Stanner wrote:
> > dma_fence_timestamp() tests two fence flags with test_bit(), not
> > providing any ordering.
> > 
> > The while loop + cpu_relax() seem to satisfy the desire to avoid
> > locking, effectively rebuilding a locks spinning behavior in the rare
> > case that a fence is signaling right now. Contrary to proper locking,
> > however, correct memory ordering is not guaranteed.
> > 
> > Ensure correct ordering with locking.
> 
> My words when I tried to clean that up the first time: "Another
> alternative would be to grab the spinlock when that happens."

:)

> 
> I don't remember the story why the busy loop was used and can't see
> any reasons why it wasn't done this way in the first place.

I reached a point where I don't even want to know the story. Whatever
the reason is, it will be something insane <.<

> 
> But my suggestion is to completely drop the
> DMA_FENCE_FLAG_TIMESTAMP_BIT as well. As far as I can tell that was
> only added as indicator that the timestamp is set, but we do that now
> for all fences anyway.

Agreed, but the API has been ossified by amdgpu who again violates
layering with drm_sched and by i915, who does something extremely weird
in intel_breadcrumbs.c. They seem to have built their own fence there.

amdgpu should be portable though.


P.

  reply	other threads:[~2026-11-20 13:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:18 [PATCH 0/3] dma-fence: Fix timestamp memory ordering Philipp Stanner
2026-11-19 13:18 ` [PATCH 1/3] dma-buf/dma-fence: Ensure correct ordering in dma_fence_timestamp() Philipp Stanner
2026-11-20  9:33   ` Christian König
2026-11-20 13:23     ` Philipp Stanner [this message]
2026-11-19 13:18 ` [PATCH 2/3] dma-buf: dma-fence: Add dma_fence_overwrite_timestamp() Philipp Stanner
2026-11-20  9:38   ` Christian König
2026-11-20 10:01     ` Philipp Stanner
2026-11-19 13:18 ` [PATCH 3/3] drm/sched: Fix memory ordering with dma_fence_overwrite_timestamp() Philipp Stanner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e037df8633ca4b4f898d9d29be76bd569709eca.camel@mailbox.org \
    --to=phasta@mailbox.org \
    --cc=Yunxiang.Li@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=aliceryhl@google.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=phasta@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tvrtko.ursulin@igalia.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®