Re: [PATCH v5 4/6] platform/x86: samsung-galaxybook: Transition new firmware_attributes API

["Thomas Weißschuh" <linux@weissschuh.net>]

On 2025-07-05 00:33:59-0300, Kurt Borja wrote:
> Transition to new firmware_attributes API.
> 
> Defining firmware_attributes groups statically through
> DEFINE_FWAT_ENUM_GROUP() incurs in a minor ABI change. In particular the
> display_name_language_code attribute is no longer created. Fortunately,
> this doesn't break user-space compatibility, because this attribute is
> not required, neither by the ABI specification nor by user-space tools.
> 
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
>  drivers/platform/x86/samsung-galaxybook.c | 244 ++++++++----------------------
>  1 file changed, 61 insertions(+), 183 deletions(-)

<snip>

>  
>  static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook)
>  {
> +	struct fwat_device *fdev;
>  	bool value;
>  	int err;
>  
> -	err = devm_mutex_init(&galaxybook->platform->dev, &galaxybook->fw_attr_lock);

The mutex is still used, so this can't be removed.

> -	if (err)
> -		return err;
> -

<snip>