mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Anson Huang <Anson.Huang@nxp.com>,
	shawnguo@kernel.org, Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, fabio.estevam@nxp.com,
	Abel Vesa <abel.vesa@nxp.com>, Richard Liu <xuegang.liu@nxp.com>
Subject: Re: [PATCH] soc: imx: gpcv2: correct PGC offset
Date: Tue, 29 May 2018 17:02:31 +0300	[thread overview]
Message-ID: <0e0690c89b24b4b028e4a0dab63334af4b37fdd3.camel@nxp.com> (raw)
In-Reply-To: <1527580944-10043-1-git-send-email-Anson.Huang@nxp.com>

On Tue, 2018-05-29 at 16:02 +0800, Anson Huang wrote:
> Correct MIPI/PCIe/USB_HSIC's PGC offset based on
> design RTL, the value on Reference Manual are incorrect.
> 
> The correct offset should be as below: 
>  
> -#define PGC_MIPI			4
> -#define PGC_PCIE			5
> -#define PGC_USB_HSIC			8
> +#define PGC_MIPI			16
> +#define PGC_PCIE			17
> +#define PGC_USB_HSIC			20
>  #define GPC_PGC_CTRL(n)			(0x800 + (n) * 0x40)
>  #define GPC_PGC_SR(n)			(GPC_PGC_CTRL(n) + 0xc)

This gpcv2 driver is currently only used for PCI, it probably only
works because domains happen to be turned on by default?

On imx7d upstream platform suspend is not yet supported but even doing
device-level suspend causes a hang on resume somewhere in PCI on first
read. This patch fixes that immediate hang.

After suspend/resume lspci is broken (device doesn't properly resume),
that probably requires more imx pci patches and unrelated to pgc.

--
Regards,
Leonard

  reply	other threads:[~2018-05-29 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  8:02 Anson Huang
2018-05-29 14:02 ` Leonard Crestez [this message]
2018-05-29 23:16   ` Andrey Smirnov
2018-05-30  1:38   ` Anson Huang
2018-05-29 23:11 ` Andrey Smirnov
2018-05-30  1:00   ` Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e0690c89b24b4b028e4a0dab63334af4b37fdd3.camel@nxp.com \
    --to=leonard.crestez@nxp.com \
    --cc=Anson.Huang@nxp.com \
    --cc=Linux-imx@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xuegang.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®