From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB9E2C433FE for ; Fri, 8 Apr 2022 12:02:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235367AbiDHMEr (ORCPT ); Fri, 8 Apr 2022 08:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235364AbiDHMEo (ORCPT ); Fri, 8 Apr 2022 08:04:44 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CEA48E1B1 for ; Fri, 8 Apr 2022 05:02:38 -0700 (PDT) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 238C2PMO129047; Fri, 8 Apr 2022 07:02:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1649419345; bh=hDLNodDdpi6TZWA1AbU7VZjdLOyyX1KQ7LxqGnZ4BvI=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=RnzC8HD8GegY0rJpt24BgykwZQ1r5Nqp/7+uKuORKNN9VF/xbyU1mGKXJf0e5At1y NADJxx9G3Oj4brYGKt17KZziTVoyuCSDpxy0d8X4HSNciHUaZG6kg7O3OvXBX1z4Gw BPCSe+pruCO1rcwTu3REQXt02vwHJG8a8xroBcjs= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 238C2Prt009926 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 8 Apr 2022 07:02:25 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 8 Apr 2022 07:02:24 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 8 Apr 2022 07:02:23 -0500 Received: from [128.247.81.242] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 238C2Nmq061776; Fri, 8 Apr 2022 07:02:23 -0500 Message-ID: <0e0c98d9-d6a9-cd02-a67d-53492614e8ae@ti.com> Date: Fri, 8 Apr 2022 07:02:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] soc: ti: pruss: using pm_runtime_resume_and_get instead of pm_runtime_get_sync Content-Language: en-US To: , CC: , , , Minghao Chi , Zeal Robot References: <20220408080853.2494292-1-chi.minghao@zte.com.cn> From: Dave Gerlach In-Reply-To: <20220408080853.2494292-1-chi.minghao@zte.com.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/8/22 03:08, cgel.zte@gmail.com wrote: > From: Minghao Chi > > Using pm_runtime_resume_and_get is more appropriate > for simplifing code > Looks good to me. Reviewed-by: Dave Gerlach > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/soc/ti/pruss.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index b36779309e49..0e4ba0f89533 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -279,10 +279,9 @@ static int pruss_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, pruss); > > pm_runtime_enable(dev); > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > dev_err(dev, "couldn't enable module\n"); > - pm_runtime_put_noidle(dev); > goto rpm_disable; > } >