From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753534AbcFLLit (ORCPT ); Sun, 12 Jun 2016 07:38:49 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:33712 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbcFLLir (ORCPT ); Sun, 12 Jun 2016 07:38:47 -0400 Subject: Re: [PATCH v2 07/17] sh: Passing FDT address on zImage To: Yoshinori Sato , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org References: <1465714475-24111-1-git-send-email-ysato@users.sourceforge.jp> <1465714475-24111-8-git-send-email-ysato@users.sourceforge.jp> From: Sergei Shtylyov Message-ID: <0e0cfaed-6109-c98f-02b8-99d9199ef2db@cogentembedded.com> Date: Sun, 12 Jun 2016 14:38:46 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465714475-24111-8-git-send-email-ysato@users.sourceforge.jp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/12/2016 9:54 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > arch/sh/boot/compressed/head_32.S | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/sh/boot/compressed/head_32.S b/arch/sh/boot/compressed/head_32.S > index 3e15032..ef70454 100644 > --- a/arch/sh/boot/compressed/head_32.S > +++ b/arch/sh/boot/compressed/head_32.S > @@ -11,10 +11,11 @@ > > .global startup > startup: > + /* Save FDT address */ > + mov r4, r13 > /* Load initial status register */ > mov.l init_sr, r1 > ldc r1, sr > - > /* Move myself to proper location if necessary */ > mova 1f, r0 > mov.l 1f, r2 > @@ -83,7 +84,7 @@ l1: > /* Jump to the start of the decompressed kernel */ > mov.l kernel_start_addr, r0 > jmp @r0 > - nop > + mov r13,r4 Forgot a space after comma? Is it a delay slot BTW (judging by extra indentation)? [...] MBR, Sergei