mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: Satyajit Roy <edu042sjroy@proton.me>, amd-gfx@lists.freedesktop.org
Cc: harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@gmail.com, simona@ffwll.ch, jerry.zuo@amd.com,
	wayne.lin@amd.com, yan.li@amd.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Satyajit Roy <sroy14@alum.utk.edu>
Subject: Re: [PATCH 0/3] drm/amd/display: Fix HDMI RGB quantization updates
Date: Tue, 8 Sep 2026 13:36:14 -0600	[thread overview]
Message-ID: <0e0dec3b-df41-4e9d-b975-57ff9a3ee856@amd.com> (raw)
In-Reply-To: <20260830035120.937992-1-edu042sjroy@proton.me>

Reviewed-by: Alex Hung <alex.hung@amd.com>

On 8/29/26 21:51, Satyajit Roy wrote:
> [Some people who received this message don't often get email from edu042sjroy@proton.me. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: Satyajit Roy <sroy14@alum.utk.edu>
> 
> The Broadcast RGB implementation currently has three gaps in the AMD
> Display path:
> 
>    1. DM does not propagate the sink's RGB quantization-range
>       selectability into DC, so the HDMI AVI InfoFrame Q field remains at
>       its default value.
>    2. BT.2020 RGB output is always selected as full range, so an explicit
>       Limited setting has no effect in HDR modes using BT.2020 RGB.
>    3. A property-only range transition updates the output CSC but does not
>       rebuild and program the InfoFrame, leaving the sink with stale range
>       signaling.
> 
> Together these can make the transmitted pixel range and the range inferred
> by a television's automatic black-level setting disagree.
> 
> Patch 1 propagates the EDID QS capability. Patch 2 honors Limited for
> BT.2020 RGB and adds KUnit coverage for both BT.2020 connector colorspace
> values. Patch 3 rebuilds InfoFrames whenever output_color_space changes.
> 
> Validation performed on amd-staging-drm-next at the base commit below:
> 
>    - scripts/checkpatch.pl --strict: no errors, warnings, or checks
>    - x86_64 AMD Display KUnit configuration built with CONFIG_WERROR=y
>    - new EDID-capability and BT.2020 quantization KUnit cases compiled
> 
> Equivalent changes were also tested on an HDMI 2.1 television with a
> Valve Linux 7.2 kernel. The television's automatic black-level selection
> followed Full-to-Limited and Limited-to-Full transitions in SDR, HDR, and
> HDR with VRR active. No modeset or visible link blank was observed.
> 
> Satyajit Roy (3):
>    drm/amd/display: Propagate HDMI RGB quantization selectability
>    drm/amd/display: Honor Broadcast RGB for BT.2020 RGB output
>    drm/amd/display: Rebuild InfoFrames on output color space changes
> 
>   .../display/amdgpu_dm/amdgpu_dm_connector.c   | 10 +++--
>   .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |  1 +
>   .../tests/amdgpu_dm_connector_test.c          | 37 +++++++++++++++++++
>   .../amdgpu_dm/tests/amdgpu_dm_helpers_test.c  |  2 +
>   drivers/gpu/drm/amd/display/dc/core/dc.c      |  3 ++
>   5 files changed, 50 insertions(+), 3 deletions(-)
> 
> 
> base-commit: 75a5e1b6b3661c3f946885d01eebeb6b031035ef
> --
> 2.51.1


      parent reply	other threads:[~2026-09-08 19:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30  3:51 Satyajit Roy
2026-08-30  3:51 ` [PATCH 1/3] drm/amd/display: Propagate HDMI RGB quantization selectability Satyajit Roy
2026-08-30  3:52 ` [PATCH 2/3] drm/amd/display: Honor Broadcast RGB for BT.2020 RGB output Satyajit Roy
2026-08-30  3:52 ` [PATCH 3/3] drm/amd/display: Rebuild InfoFrames on output color space changes Satyajit Roy
2026-09-08 19:36 ` Alex Hung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e0dec3b-df41-4e9d-b975-57ff9a3ee856@amd.com \
    --to=alex.hung@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=edu042sjroy@proton.me \
    --cc=harry.wentland@amd.com \
    --cc=jerry.zuo@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sroy14@alum.utk.edu \
    --cc=sunpeng.li@amd.com \
    --cc=wayne.lin@amd.com \
    --cc=yan.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®