From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20875389472 for ; Mon, 20 Apr 2026 08:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776674711; cv=none; b=QJ2woEJ2yDEUFHX7//T8sBpBaB2Yb5e31pN14Admzppyk5wPoMgPa+jSPIWa/q7iwaRYWsUK06V+xferspSoG54dfSmtueHf1TZ251fStpFx+SfGAhX6U0q5gElbDqi/bT069sMhd/B+wv0NM2lIqptpzt3Yszmy71qWnB1GbQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776674711; c=relaxed/simple; bh=1f3+FY0eODonk77L71n/GWv2Bu4Zn306GljTsgpHpbw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jSD/z4Bp+bwDZKV37+4MuI3yxE4R5rjNkh24MN69jfLNcPuXmMgilODvlwZiU+iR7i6CkiU+tC/S8kmlLDJqelTw/HCqZion5Xud3QpeFwf2XoenVVCcNdtmd5OYA+MB+IrFZotQ0a4e8oj29nFF2Y9jRMt3Z226AmFhjvZEfww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q1yD6pV4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RxffZpr6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q1yD6pV4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RxffZpr6" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63K7LbZD2386855 for ; Mon, 20 Apr 2026 08:45:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VJ5z6Lev2AQUyalN7zgWolbBiaRJ+GEDL5W9uP32NnY=; b=Q1yD6pV4A2WpcqSm NNJtnzkyYqipACF5WIzhuzXoDJTRlOgBxgMcetvBi/SIbcoFU2S+/oLm5vfbxmqk DQsMrVgPnJ9qPml7fbTCYQS111qy1POhyRUkOH4ZAAZ75dHBcw+LQr94rtXMdtmQ ex2ypop60hNV5OsJHgva8qicJ8PR0ocglv3vmoGyGL1CmEItm97xpXc8Vo7/FUbn F+UK45W3QkMuGU5K+nVdS1V5SDzw7FEUwGeP843oWCH53ykultIBoJ2+d7PUmzHI 8+N7d43ZWWaBlj7O+/DuCF1dKecdaZkHeEyZPNx0jM9Xo1NJeToE7Av0inZkcwzy N66J5g== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dm2qan39b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Apr 2026 08:45:09 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35e56ed5d5bso4240258a91.0 for ; Mon, 20 Apr 2026 01:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776674708; x=1777279508; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VJ5z6Lev2AQUyalN7zgWolbBiaRJ+GEDL5W9uP32NnY=; b=RxffZpr6Dmh+P0pz24oDgGGxnD3Cui4Oom/g/FM8Kugt8wgllAZ4Sn/xovsumQOIeI 3IQY8sZlEn4vKG1w0GDwXEomK8Lo/hHfOEOhzLTNcDtb06tMeQDYoUd7Y/CqMLwUM4Ka 0ktV4vmjgypR+kY+Tf43FAcTq40US28uUiYKjZU+BqRztxBl95TeHfWJBFSqdkgZdXku DZ/bOosrOOw7FJhu8QSW62jzc4Kp5+Jdj7vJarBi3jHrfdoOFv4KBI1rR8M28mmM5xBc iXBpAPYNDiPFyV/2GSS+emQzW9TxQD2n2ud+2GT0qEYqHA3gSi7EFElN5Um1gb3/gGW8 ablQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776674708; x=1777279508; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VJ5z6Lev2AQUyalN7zgWolbBiaRJ+GEDL5W9uP32NnY=; b=lyL0/PRuqPyRq02NeeH6QpdMkvpHX+8uCrB/JUHaVGx2sFQ1OXL/T98wDzbN45M6Jn jz7eQeEPaGXNDzh6b9I+ELV5shurxcbhfCWS87ZT8KK3IRUt3Ddj2zbyu/Zy0lUO2peX INLw3dk8whW/rGh9xgcIFCj7IICUDZeaHbo+NMs82RiOB9cAp4OTnb1tnD2NuOI4mA4t ukni44oy+S/H8ZHmVspfEEVO5y9CeFOpsB0nEqZlriH/J7Bk5L8gmovvRGlb9LFacYxH k7FCwz/x+WxId8tEghBVOcA7C+dBax05UwlEaGU9Y4WtXvj/cMVsqmx4gCFEYuywUpGw o/wA== X-Forwarded-Encrypted: i=1; AFNElJ9dG0GdzZQIurwx/PcVoSX4Ua1GEsVgWA/yiYaz+FpQJnZKE4y9TxEe06R0vI0S0+oBKSSb2i1ndQ2hnZI=@vger.kernel.org X-Gm-Message-State: AOJu0YwguEtdOhoj9WMh5YvmanvDSQ0p+74BWWlnsVjIjUC8tL5y1jKh zGp2BswI2dmdlxyPZfMEJS/12ucwA8ApK2KH8gLU4pVpCCXwwuXHrrAXjXYvsKrlea4Vr9gZXiM R4GIt+yNOr6fCo5cl5tmb0aWCWLodkyEvQ3jPB7tSZr9zK4OAPuvqtPeaMsxNAnwhm2JmR5TdEq k= X-Gm-Gg: AeBDieurR1QLBFJwlit3gu8cBtnzKaJ3d7Z/KagiI1fydyAJ4iqU7R9Nxghdqm6RO4b N/b/ppM1wSb351Z8gIUs3h1opQaGIn+b4rgWCTaBsAr13F2FxZS0d/0bWg4IlHI39mOa7i4tfm3 KayUzZdN8OK5/l0NNXPasUt92kX6gAjrpOb/0q/hdKh+SWo6DoWVvBy0U323fM4ZKrPyrm0SbMD xhIZVmI3NHbRl/UneEl4i6Hw2wOeTnHQKq+FHX8khOyZP4hNsfElk1R28/EmRB03aqxVrgcB5G2 i4SONWVbDPmNHtUMVQdQibY1CV4/8rUdS/HSnepVe7ZXoruGXGlccWv3Oip/hOUgE9lsmoWotnU DJD+UhxncxncHtYbNihKk7meoDzHiacJEasX4oXCn/dYCW3nuUpA1t4ykWPo2 X-Received: by 2002:a05:6a20:938e:b0:398:6ec6:b06d with SMTP id adf61e73a8af0-3a08cd3782fmr10319175637.34.1776674708028; Mon, 20 Apr 2026 01:45:08 -0700 (PDT) X-Received: by 2002:a05:6a20:938e:b0:398:6ec6:b06d with SMTP id adf61e73a8af0-3a08cd3782fmr10319125637.34.1776674707137; Mon, 20 Apr 2026 01:45:07 -0700 (PDT) Received: from [10.219.49.106] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797701d880sm7255649a12.20.2026.04.20.01.45.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 01:45:06 -0700 (PDT) Message-ID: <0e0ff9bb-5f61-49bd-8c6c-811e1687ce6b@oss.qualcomm.com> Date: Mon, 20 Apr 2026 14:15:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] pinctrl: qcom: lpass-lpi: Resume clocks for GPIO access To: Konrad Dybcio , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com References: <20260413122233.375945-1-ajay.nandam@oss.qualcomm.com> <20260413122233.375945-4-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: NhW6Y5N60HT13LJmxvkUHMdPtNeQ4jXi X-Authority-Analysis: v=2.4 cv=KdDidwYD c=1 sm=1 tr=0 ts=69e5e795 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=THQc4dpt17BYfH4AucgA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: NhW6Y5N60HT13LJmxvkUHMdPtNeQ4jXi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDA4MiBTYWx0ZWRfX2ticPWNrs7SC CbAYhVgtAl+Kj2BAWpeqy7cyjmbdssOQPxGR5w6AU16XSujUyiDuHH8oW1dljCc3fiL2CZOctCw krGDFrT2blEtEJ4XCY56aQ4TWqUJcw2prKnIRvrONdlZGWJVcIyOaASCxKv54ktBaC5JpRfIC37 6xZnNIPOA1XHchtZBVLinWort4HP1FD02F+ZFRK4A3VUpv8Ly0YnswO6hD73boFsDfUrqa9ZwH1 8+U/Dy3FjtJ6tfiFshB0Gk2yGNsaiA7VjlGzgLRqGPprsRyqT0ePgeHVHwxg0Rth3tRHlmoJL+H thFjUsbPmyRsAruVf3c3i4cPiuv+4qTZinWFVm2X1B2FCyYScAcDtd8+qZxzEbsrypJWVP3PM8n oy9wFdGen3+ZiXwiGE/Zt4X7RvVr6oI6x5dXVE6W8jsC7Dsb5PbUXfSTd+EruCYiUuhwzBLt/tA vTIQ5AziWFJMlkYoWIA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_01,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200082 On 4/14/2026 2:14 PM, Konrad Dybcio wrote: > On 4/13/26 2:22 PM, Ajay Kumar Nandam wrote: >> Ensure the LPI pinctrl device clocks are runtime resumed >> before accessing GPIO registers and autosuspended after >> the access completes. >> >> Guard GPIO register read and write helpers with synchronous >> runtime PM calls so the device is active during MMIO >> operations. >> >> Signed-off-by: Ajay Kumar Nandam >> --- >> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> index d108e7321..4275f2734 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c >> @@ -49,8 +49,17 @@ static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int pin, >> else >> pin_offset = LPI_TLMM_REG_OFFSET * pin; >> >> + ret = pm_runtime_get_sync(state->dev); >> + if (ret < 0) { >> + pm_runtime_put_noidle(state->dev); >> + return ret; >> + } > > Okay that's how they can fail.. > > Please move from pm_runtime_get_sync() to pm_runtime_resume_and_get() or > someone will come around next week to "improve" it ACK, Will update the patch accordingly and post v2 > >> + >> *val = ioread32(state->tlmm_base + pin_offset + addr); >> >> + pm_runtime_mark_last_busy(state->dev); >> + pm_runtime_put_autosuspend(state->dev); > > put_autosuspend() already does mark_last_busy() nowadays ACK, Will update the patch accordingly and post v2 Thanks Ajay Kumar Nandam > > Konrad