mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: [PATCH] build-id: require program headers to be right after ELF header
Date: Fri, 21 Jun 2024 18:05:50 +0300	[thread overview]
Message-ID: <0e13fa2e-2d1c-4dac-968e-b1a0c7a05229@p183> (raw)

ELF spec doesn't require program header to be placed right after
ELF header, but build-id code very much assumes such placement:

	find_get_page(vma->vm_file->f_mapping, 0);

and later check against PAGE_SIZE.

Returns errors for now until someone rewrites build-id parser
to be more correct.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 lib/buildid.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- a/lib/buildid.c
+++ b/lib/buildid.c
@@ -73,6 +73,9 @@ static int get_build_id_32(const void *page_addr, unsigned char *build_id,
 	Elf32_Phdr *phdr;
 	int i;
 
+	if (ehdr->e_phoff != sizeof(Elf32_Ehdr)) {
+		return -EINVAL;
+	}
 	/* only supports phdr that fits in one page */
 	if (ehdr->e_phnum >
 	    (PAGE_SIZE - sizeof(Elf32_Ehdr)) / sizeof(Elf32_Phdr))
@@ -98,6 +101,9 @@ static int get_build_id_64(const void *page_addr, unsigned char *build_id,
 	Elf64_Phdr *phdr;
 	int i;
 
+	if (ehdr->e_phoff != sizeof(Elf64_Ehdr)) {
+		return -EINVAL;
+	}
 	/* only supports phdr that fits in one page */
 	if (ehdr->e_phnum >
 	    (PAGE_SIZE - sizeof(Elf64_Ehdr)) / sizeof(Elf64_Phdr))

             reply	other threads:[~2024-06-21 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 15:05 Alexey Dobriyan [this message]
2024-06-21 17:07 ` Andrew Morton
2024-06-21 18:32   ` Alexey Dobriyan
2024-06-21 18:39   ` [PATCH v2] " Alexey Dobriyan
2024-06-24 11:23     ` Jiri Olsa
2024-06-25  3:28       ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e13fa2e-2d1c-4dac-968e-b1a0c7a05229@p183 \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®