From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4702874F9 for ; Wed, 11 Jun 2025 13:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749647140; cv=none; b=n7cohyw45MQzxtEci/i9wXSgP+6I5O/h2mkdsvMwcWW/88wK9F4hf1bCzspXrELmSoCwBTTJR66YjlbHmNzRD9nAk+yf92Sddh2sanjUnQiCFqSHSvpwb7IxMpTHJbIKcdg+5gn8+8KlmGOCOny1lkEsnN6mFfNF//GQk6qVHUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749647140; c=relaxed/simple; bh=EjVY2ArlQ4qGt0K73z9GDztVoL7a90MNu70YfxiFca8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L8Ms3PlzRExSrcQYlpXGGv3sD3iz5HWFFcwFX37j4VrecTNjSWaWzf/Eb7+CPYa5BfZQbKjvkOlFuHJDgmWv4gfXKsMRsh3tgGGl8b6UozLtVH+Euw4Bx+5sZFpIcpcnH77mgNzjjqq9gvh++ki9ZN3dmr2pQXBiIK2cCxm4UOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x9PQQeTz; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x9PQQeTz" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-451e2f0d9c2so7929365e9.1 for ; Wed, 11 Jun 2025 06:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749647136; x=1750251936; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X3R09Iyu+oVEvrLJByqrLxu4/r9hm8EBVtdwnnJnPEk=; b=x9PQQeTzy3IXKBRpR4zz1vRcjNz1UqBcdJnRxpRqPQ5BJ1zdDDk7rTCyplxj1ja7o7 H0IwxvhW8b0CoK1Zfi8vcwanQKReI02MnD7aO4/TL9Z9SxjIDQRfabRAJFtkIX5d0Z8B DuKhD0WQVNSSdcYDzRHhXK4PDhpo/bCqW+62vcpiL2UQJzyye0Mca1nUxnQkufrucfXa crx6NoAjLxi5rjLMTl54QAmnbw2ebUKNO51eVOBsX/w3yaAOTk2WIDHoHIRSj5QnMlvQ 87VmpEm0a1WZOUHmzk6W7o/o4JEfHDJOkmVBk4TorWNQWAbKMoExmg66UJToCijzyt0j OcuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749647136; x=1750251936; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X3R09Iyu+oVEvrLJByqrLxu4/r9hm8EBVtdwnnJnPEk=; b=YGD6BIMWOs83I+pLC9ZKVp9P8RXNXEuBGFINmp+k/erOaO9sM02mwonaffCQHwu0fg Vim9YBXn92kOrphWNIy8VpSdee59XvE/RriAMXrUvUuHSp/KJ1UvoC9q/trgqHA/8NWv x0++k0+xG/mHlM6rQ9NfTcbOcebGj7DtUz5BCMhbbrBNAcOrbaecUWJ8LkhK/XG/iwA4 shsaq5XPF0NH+SH0wQK1lt1h4UWe366aT4fSuPjhx2aINVmlyGXIcjpAgH1WIJUdVZmY Mgz7/+Zs7cK1MdXNS221m6SgjzOQKPV0PY+9jruP6V3XJnbkvImZz1jjf2zE2vRARIbF RAkQ== X-Forwarded-Encrypted: i=1; AJvYcCUKYey5VDd2TJmN88kTJ7jvuGg5TjbWDQESjtmMGp02xqlInVIez/qz/MgWZy0JPx185POPbMP2oYcE7Gs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7oC7vKIleRbys5b+5Vev/iV6EQukoCktvJdbEXHOboY94OJKR byW+jmmehKm733gltDqotnW6Rq95k5+ctDfSBq9Jo6pcBxm+E39VkHfW5BhNadeEm9A= X-Gm-Gg: ASbGncvSV+hq9tGC/1lj36ivmVQs/sRQUSViV4b20i3MiaOwHtAtIspYqqyJfHB00Nx EfZ4odb66iGgiy+K8PuOjukUQ3f2Ax5kTTzHxSnhzYI6F+Bq5UaHotlO/hppLtwdUdFtKh2TnWd h87io5sF7eVagnCyVscn2DZdBDChO1oqgCzGNSNlsHeSuwE52ZieERtZHVpGw8NiyCczLSjZHQS t2rSzPHcrw29D4tr7J0IwhHmYegNx9Hp3HtaLY9V+LFmdSsuiGyT8LVBT1FbC8c7MxSatutFZRO Xz1tulS2rBzcm/5yddLI02xHQtP7/Ig9dnjpCws8ezW4SnGAuElYYy8rXUoaJf3aVRiBpJLoLdg /itU9ChZusNC2rJ9z3qy1oiKNJNZm+9G2oTlyFr8ChRwlzzeejUzHm3dJ X-Google-Smtp-Source: AGHT+IE/+ZF0202H2gGrgjMZ/XMTAOBrohuHjeBubUtp7vBfdN9DADireHyArZ8FK4FEDHt2MkhIeg== X-Received: by 2002:a05:600c:314c:b0:439:4b23:9e8e with SMTP id 5b1f17b1804b1-453240b0e39mr34289735e9.3.1749647136238; Wed, 11 Jun 2025 06:05:36 -0700 (PDT) Received: from [192.168.1.105] (92-184-112-57.mobile.fr.orangecustomers.net. [92.184.112.57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45325141397sm21364185e9.8.2025.06.11.06.05.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jun 2025 06:05:36 -0700 (PDT) Message-ID: <0e1ae53e-e2a9-44ec-a59b-432bbf8d4b49@linaro.org> Date: Wed, 11 Jun 2025 16:05:34 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dmaengine: mediatek: Fix a flag reuse error in mtk_cqdma_tx_status() To: Qiu-ji Chen , sean.wang@mediatek.com, vkoul@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, stable@vger.kernel.org, kernel test robot References: <20250606090017.5436-1-chenqiuji666@gmail.com> Content-Language: en-US From: Eugen Hristev In-Reply-To: <20250606090017.5436-1-chenqiuji666@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/6/25 12:00, Qiu-ji Chen wrote: > Fixed a flag reuse bug in the mtk_cqdma_tx_status() function. > > Fixes: 157ae5ffd76a ("dmaengine: mediatek: Fix a possible deadlock error in mtk_cqdma_tx_status()") > Cc: stable@vger.kernel.org > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202505270641.MStzJUfU-lkp@intel.com/ > Signed-off-by: Qiu-ji Chen Reviewed-by: Eugen Hristev > --- > V2: > Change the inner vc lock from spin_lock_irqsave() to spin_lock() > Thanks Eugen Hristev for helpful suggestion. > --- > drivers/dma/mediatek/mtk-cqdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c > index 47c8adfdc155..9f0c41ca7770 100644 > --- a/drivers/dma/mediatek/mtk-cqdma.c > +++ b/drivers/dma/mediatek/mtk-cqdma.c > @@ -449,9 +449,9 @@ static enum dma_status mtk_cqdma_tx_status(struct dma_chan *c, > return ret; > > spin_lock_irqsave(&cvc->pc->lock, flags); > - spin_lock_irqsave(&cvc->vc.lock, flags); > + spin_lock(&cvc->vc.lock); > vd = mtk_cqdma_find_active_desc(c, cookie); > - spin_unlock_irqrestore(&cvc->vc.lock, flags); > + spin_unlock(&cvc->vc.lock); > spin_unlock_irqrestore(&cvc->pc->lock, flags); > > if (vd) {