From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9973B8D41 for ; Fri, 24 Jul 2026 23:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784937168; cv=none; b=j36wnpLbCVKm7/6QJqLO+zT8XRAowKwvxE8TxYXmT3Q7O+eX1ekkwC55tVG3KEdg+Eedxf42VGH/qEHcV7rl8ZFkLbqufQsz/JTo9BjxvGbyh2IlmXvuVsbo4LBPwULKbIFaAK/00CRjAbGO9LUC4qOFdV2QpADSau/obTzF5Ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784937168; c=relaxed/simple; bh=6jgi5uf8lN09V6KOs0hDsV2OU3CHDba7Xeqy944ou0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e+JK9/eA9fP2j9RhtSqSZLk7GY7OlEMPCKfCC/Dpg6C06onrZZsHXC3VwOvt1g4//M3gmlQwfT0xIOe2MF7jAivdKlxVguAULYs0ItrbsgkzcJESZMzk3EFdOAzJiVJb9UwXl9Rk2qEpNwXbboNn8cViUaHllowHdPDszeXogps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G5ok+djX; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G5ok+djX" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47ddf7b09aaso529165f8f.3 for ; Fri, 24 Jul 2026 16:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784937165; x=1785541965; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OayzebvdJM9fG6lnwaS3h5fCYnIaMiJiswcoAgkXblM=; b=G5ok+djX7UUafmjhSx65cj5pnHgkhYwj8B0Jhkq0WzR2wcxxiBHps543//JR/+hIiN 2nU7jK6woUTJd6eN/Ld2KB6RaOafCe75z1BtdCihmw77fQ0eH8LCqYmD4RkIrwww6EEe QFwqMssYmL5V0wBgATURFB7vZOJbVEV9G7RsYFylKW+p5e+Dd82M9n/v6owfYmWEGmuh ELYh2dotGec497AhbLHqBcwVQ0VSy9NGeFY5hbSrdRPAj2QVsHeOhBYE5EEg99YH20jI HK7NmfjmCLL7D72S1lr1nPbtU2VRg4bCQbLcVId59BV7xMUZNTD+ZdG/sN+bDyCSKHIQ kE2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784937165; x=1785541965; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OayzebvdJM9fG6lnwaS3h5fCYnIaMiJiswcoAgkXblM=; b=GEtT4g9yDdXdCHptq7o+Gk7sEAKK+jmZ3SNLNcymA+/RqWWGDygXiRRdCBLSNovjIN Ef2u2sB1R7Wd2anuxZXdfR3xzzXZkDIC+tSKgmx28MXNGDjC3SQC8a0Vy8JKZYOUE07N U24OhO6UfxRcQhBErH0+vnXq2+jiEzEpopayhvmwu3ennhqAhVPpOdOsovpiuIqjQlAM IBP67aPvJiVoUGCAupRQ2QKoLJB3DHTa4rMLGhDFJz1C3pPZ0fDb17IgqkyXEj3x0Xyf p9wt0ox9ZuL/7i9/S2uMRsTFMrjXZ8OF+anp3EKiiZ2uUBkmccK+PrMk3WYdqi3oxqXq 1CLw== X-Forwarded-Encrypted: i=1; AHgh+RrX45zdO503nHgcZcJQ76KxJ1JTjgHmcm/apGSa1/xFLQAQAP1rDHBljjrOq2ySIxhsvpxL6BbWCGfrtnA=@vger.kernel.org X-Gm-Message-State: AOJu0YwEE1w/qq86HF1E6it3GGC/hQqXkmgNjj8LQXeQW/TZkwEzdFfr VOFoNbz6wBdBjZs54bXmkBjDxTXK3kF+PX3JAXoCfKkGyIJNeomVy+uPQeGFhA== X-Gm-Gg: AR+sD130naTL3PjYKNto0Vveqd8mWv8KywDubmdwJtMD3Ao40gqMiZSPx9N5IeEvWBD rCWntfE39xN6SyAacHsqNkI3jKpbcP73y1SNbzzsJvsOuQsR1cC//X6ESx21mppx9ZA8E/CUj4u e1z57L93jT00IUYc4XTJc4CAFa84I+H0LO4y9o/LFIWWqozY8HdARHeha27Kl1oz03oEMpkpNKP KQoagUmxhp9ERBi3oW54HDVHg5kgfhInluBO4M8+g/M2y7FebGCCCBWYtuLkMarl9LJC14QW3lA FtufaSmO5bp3rMmY5cKsak8Af4m5KqW2/wPUIH2xiZdTvotyxQvHZrda60nUuVk4dBW0aKoqS7n a610+YESMBO8ISavx+JjG3xZhhT3UMMC0vZ1oi28WD2Bf4Zuf+XCuuqmmP1NdMog1S5ryDhX7DG 6GZicwpz3ovLY9Bx5sBvw= X-Received: by 2002:a05:6000:2403:b0:47f:81fe:12fb with SMTP id ffacd0b85a97d-47f9fea0180mr247027f8f.47.1784937165566; Fri, 24 Jul 2026 16:52:45 -0700 (PDT) Received: from [192.168.1.50] ([79.118.68.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85bd77a9sm26365337f8f.14.2026.07.24.16.52.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 16:52:44 -0700 (PDT) Message-ID: <0e1c1d85-6042-4464-9cd0-c93d0a4a2f1c@gmail.com> Date: Sat, 25 Jul 2026 02:52:42 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/19] wifi: rtw88: fw: send the media status report in the vendor layout To: luka.gejak@linux.dev, Ping-Ke Shih Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Straube , Peter Robinson References: <20260724181858.192903-1-luka.gejak@linux.dev> <20260724181858.192903-7-luka.gejak@linux.dev> Content-Language: en-US From: Bitterblue Smith In-Reply-To: <20260724181858.192903-7-luka.gejak@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/07/2026 21:18, luka.gejak@linux.dev wrote: > From: Luka Gejak > > As with the rate adaptation commands, the RTL8723BS firmware expects the > vendor v5.2.17 byte layout for the media status report. The bit packed > rtw88 form leaves the firmware without a valid connect indication, so > emit the layout it parses for this chip. > > Signed-off-by: Luka Gejak > --- > drivers/net/wireless/realtek/rtw88/fw.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c > index 495d26eafdd4..87da0dd82aaa 100644 > --- a/drivers/net/wireless/realtek/rtw88/fw.c > +++ b/drivers/net/wireless/realtek/rtw88/fw.c > @@ -839,8 +839,19 @@ void rtw_fw_media_status_report(struct rtw_dev *rtwdev, u8 mac_id, bool connect) > u8 h2c_pkt[H2C_PKT_SIZE] = {0}; > > SET_H2C_CMD_ID_CLASS(h2c_pkt, H2C_CMD_MEDIA_STATUS_RPT); > - MEDIA_STATUS_RPT_SET_OP_MODE(h2c_pkt, connect); > - MEDIA_STATUS_RPT_SET_MACID(h2c_pkt, mac_id); > + > + if (rtw_is_8723bs(rtwdev)) { > + /* Vendor v5.2.17 MEDIA_STATUS_RPT: connect = 21 00 00, > + * disconnect = 00 00 00. Byte1[0]=OPMODE, [5]=ROLE(STA=0), > + * [1]=MACID_IND; byte2=MACID; byte3=MACID_END. > + */ > + h2c_pkt[1] = connect ? 0x21 : 0x00; > + h2c_pkt[2] = mac_id & 0x7f; > + h2c_pkt[3] = 0x00; > + } else { > + MEDIA_STATUS_RPT_SET_OP_MODE(h2c_pkt, connect); > + MEDIA_STATUS_RPT_SET_MACID(h2c_pkt, mac_id); > + } rtw88 doesn't fill the role field, but otherwise the layout is the same. Not sure how important the role is. The other chips work without it. > > rtw_fw_send_h2c_command(rtwdev, h2c_pkt); > }