From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BC01F3D56 for ; Tue, 3 Jun 2025 06:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748932392; cv=none; b=PyWmjfIRLUayh10ISMxnMrjrFCQ1yVW99aU3pJd5uGgqeWY18HhrBRFR9Hrh/opRokUHVMYT69n9rpWTNqFN9IPW+VxmSpnZ/IGnhzdp2BAs2s3e6ElGjOtG4WWNbpBCYDvjb44hGelSrMr6Hk2LaTtp4X5iBPDEbuAjNsN3R90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748932392; c=relaxed/simple; bh=RsGYtgtdANl/zO/ogZLbFhtRUx9OmRHuZoXn6BxbNqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PcjJk0+AVBIUQ7lO3qt9tpVBPTdlqhenQi42ag+SRE4p2XiovgZw3ZaQ1/IXu8O5Gci+in2Z9ipQWfZjs4h8yhuHeHU0OJrEHm/zY2A8rk6VG3ms6Tjo9J1iBcOaMaX7mt+v597iOMhH+vdtfDxXPVoeqYrj+YZAp5jOKxUe5lA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cwCnRELw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cwCnRELw" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 552HKKBZ008593 for ; Tue, 3 Jun 2025 06:33:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9pc6PHB6crm3zwpJbt4GLLT2Ce8F7PkqjaaH7vHbgPE=; b=cwCnRELwNaVxYI9M oAPlIZxDlM2BMVIyXkDlK9iqnPBgw5INiD+AWntbERFLygOOPqW3akmCQIgx4Cw+ VxNPrJ/sWpruPI1wwdJ9aNHapyWx10lyun/QWBp24Gg/uF1iHtUgdTK+n/IlLv3K TdIxcK6eSFl50o+ws9cjHcaueCfeJkpLJElxBTZKozc+cf8Rg0J6Q1ecGpho+M8i 6IA9JgU5/H2rYxqiifbwhNt4pm917bmrH37AxYlv5onlWBqpMXbbShtvbCnWiauw wi+L0TOOAHiDR33qj3JuRgeEwqlZRbnEzE41Pe6BVxRFy8JCdOL1wV6M0YLi9BP9 8q9l/w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 471g8yhjbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 03 Jun 2025 06:33:09 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-311ae2b6647so4170685a91.0 for ; Mon, 02 Jun 2025 23:33:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748932388; x=1749537188; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9pc6PHB6crm3zwpJbt4GLLT2Ce8F7PkqjaaH7vHbgPE=; b=TJ6wKX/y/jv4AXfleZsXzP+5ONsnvZLif/d3b8McrUGQKjnzPhJNtNzSxGmLyYVcDP u8A0ZrbBE9jC1ptIcTtxIwAA3qwh3rMlKWKVKFSDHHlWDCm48PJh5e9/FfUMhWrn9197 pp9YDRzYNv+jcUAsPZKpsA2HB/zSVmcpaEszMdmHhr+XBzApVM3cOwJtbrfMZGXEpiKs bAguYZiAxsHnIKJI03FbWvsIvQho8g3pJnhX/Hp5PJaF2L56T/jfC0b8ts4ORZKH64YA K90leinKeBjgVsShDPjcu69+J+sHtdFw8k/Dh5JR+NDu1WZW3vvWLvNYZe6EWmkk4DLY BSsw== X-Forwarded-Encrypted: i=1; AJvYcCUjBJlA2hnFsaGlR6WTXY6F93BzAIGBTj2yzpd1OYIeSGn85OKhrNfCXmJSGl4gTkBYt0/IpcPB3KRp978=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa4UFZkKnN7dJoe068GaRyAhuJIgiSnkyYFMHdyGXc17SORPV5 GR6mAK66/38cnbxh8b8xNVDNyuXYZrgrPY95JU/ILieLhe+c6crE5YP9gD/fVioBLOhokJBdtbI q7orIjl83urm+EKGZDzKBE2SsDbP751i9oIIJl26Ms4k/fFjuB2rktZTXSolZTEF/Yuo= X-Gm-Gg: ASbGncsCApBnDXZwTSanfbh7F0yARsGQ3omc4LvwqYjwI1mfTbfvvQarOARTW5xqxy5 TefXAU2IByogGTH4o8gQIqGyqD7FJmK7TVFny244jIRzyn1qkQAfgpzywBXRWhqrLq79LBBn8RQ 0GjPPzS6jCdMwOHPX95sbHNRlgOfGlia7O37v/oEZTKX4kcPSbA8WIRUWZCWAYNNSFZTgYnOqlm ERydP4ouqfHldRG3ah3KTSmnSjyq/rkJIwJFRx9kUWRS0Q/NzQbS86rOmRyTQO78Jwp0yPnOa5E oJCVJUOedGeI2S4/Ts6ZfItSHfGy0/yir+v0tXzSZw== X-Received: by 2002:a17:90b:2249:b0:312:1e41:3a5b with SMTP id 98e67ed59e1d1-3125035317fmr20383223a91.4.1748932388101; Mon, 02 Jun 2025 23:33:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG14BrL2PlcTbB07wK/qZ6PgKdgYBcfapOLCfQTa+Dc+QD3aVcsU8s27xf8IUVdxud5j5tkbw== X-Received: by 2002:a17:90b:2249:b0:312:1e41:3a5b with SMTP id 98e67ed59e1d1-3125035317fmr20383183a91.4.1748932387543; Mon, 02 Jun 2025 23:33:07 -0700 (PDT) Received: from [10.92.214.105] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e399b3bsm6562535a91.31.2025.06.02.23.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 23:33:07 -0700 (PDT) Message-ID: <0e1d8b8e-9dd3-a377-d7e0-93ec77cf397f@oss.qualcomm.com> Date: Tue, 3 Jun 2025 12:03:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 3/3] arm64: qcom: sc7280: Move phy, perst to root port node Content-Language: en-US To: Manivannan Sadhasivam Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_mrana@quicinc.com References: <20250419-perst-v3-0-1afec3c4ea62@oss.qualcomm.com> <20250419-perst-v3-3-1afec3c4ea62@oss.qualcomm.com> From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjAzMDA1NSBTYWx0ZWRfX+UX80MODBNF6 Ua8QynqJKXqjWW8Y+uKShsODAu38ygmW61WIWHRKded7yU9B0p56DPZgpctCuQYXVFa6e0arOCs gEya8a5FfnX59AavzhZYi5BarQJwe9BJcZZF/UAqcnUKKgOi+NUscIiVAC0ZfJxD6gGsFJq+70f U8Pf6uPID0cQHnOCU5j/fPjhllC7+L80MqST5YCiUlumd+ga1d4zNY2igRSmCpnIVlIbm44GCy8 ONfqPyxU9zZxEYoyFTADF6fEwL8Sn7qnJKRY6a0/dSB7yCs7CZNoVnMg8Eb843vRk0XcxUH4zp3 uYt6AHc+li6ZUVWgm0WggmrLfFH3jH5u336q/jIA9L5MCn9hwe42fmXv2BDdjzdSoXx59ZdJupN yWyZAA47o6PtaiFVZQyKhnkVjrax0d+KAJsKbVXmItT0n2lpHvOAnJzIRREbp+hK7blXM0z1 X-Proofpoint-ORIG-GUID: 6N9lRCX8dgtBo_JhDuyMbaSyeNc1SIrC X-Proofpoint-GUID: 6N9lRCX8dgtBo_JhDuyMbaSyeNc1SIrC X-Authority-Analysis: v=2.4 cv=T/uMT+KQ c=1 sm=1 tr=0 ts=683e9725 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=kQES2RtodgDv6MKcoUgA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-03_01,2025-06-02_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 suspectscore=0 impostorscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506030055 On 6/1/2025 12:35 PM, Manivannan Sadhasivam wrote: > On Sat, Apr 19, 2025 at 10:49:26AM +0530, Krishna Chaitanya Chundru wrote: >> There are many places we agreed to move the wake and perst gpio's >> and phy etc to the pcie root port node instead of bridge node[1]. > > Same comment as binding patch applies here. > >> >> So move the phy, phy-names, wake-gpio's in the root port. > > You are not moving any 'wake-gpios' property. > ack I will remove it. >> There is already reset-gpio defined for PERST# in pci-bus-common.yaml, >> start using that property instead of perst-gpio. >> >> [1] https://lore.kernel.org/linux-pci/20241211192014.GA3302752@bhelgaas/ >> >> Signed-off-by: Krishna Chaitanya Chundru >> --- >> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 5 ++++- >> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 5 ++++- >> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 5 ++++- >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++---- >> 4 files changed, 14 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> index 7a36c90ad4ec8b52f30b22b1621404857d6ef336..3dd58986ad5da0f898537a51715bb5d0fecbe100 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> @@ -709,8 +709,11 @@ &mdss_edp_phy { >> status = "okay"; >> }; >> >> +&pcie1_port0 { >> + reset-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>; >> +}; >> + >> &pcie1 { >> - perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>; >> >> pinctrl-0 = <&pcie1_reset_n>, <&pcie1_wake_n>; >> pinctrl-names = "default"; > > What about the pinctrl properties? They should also be moved. > pinctrl can still reside in the host bridge node, which has all the gpio's for all the root ports. If we move them to the root ports we need to explicitly apply pinctrl settings as these not tied with the driver yet. - Krishna Chaitanya. > - Mani >