mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: hubcap@omnibond.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vboxvideo: constify drm_fb_helper_funcs
Date: Thu, 31 Aug 2017 15:20:05 +0530	[thread overview]
Message-ID: <0e1e8c9e-932c-72eb-347f-ff95fc79164b@gmail.com> (raw)
In-Reply-To: <1ec6b9eca12e894181fd05876481c7eef7eff691.1503463899.git.arvind.yadav.cs@gmail.com>

Sorry for noise, Please Ignore this. :(


On Thursday 31 August 2017 03:16 PM, Arvind Yadav wrote:
> drm_fb_helper_funcs are not supposed to change at runtime.
> All functions working with drm_fb_helper_funcs provided by
> <drm/drm_fb_helper.h> work with const drm_fb_helper_funcs.
> So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>   drivers/staging/vboxvideo/vbox_fb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
> index 35f6d9f..70d99b7 100644
> --- a/drivers/staging/vboxvideo/vbox_fb.c
> +++ b/drivers/staging/vboxvideo/vbox_fb.c
> @@ -330,7 +330,7 @@ static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
>   	*blue = regno;
>   }
>   
> -static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
> +static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
>   	.gamma_set = vbox_fb_gamma_set,
>   	.gamma_get = vbox_fb_gamma_get,
>   	.fb_probe = vboxfb_create,

  reply	other threads:[~2017-08-31  9:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31  9:46 Arvind Yadav
2017-08-31  9:50 ` Arvind Yadav [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-21 10:06 Arvind Yadav
2017-08-21 11:36 ` Hans de Goede
2017-08-23  1:33 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e1e8c9e-932c-72eb-347f-ff95fc79164b@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=hubcap@omnibond.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome