From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939576AbdEXRDp (ORCPT ); Wed, 24 May 2017 13:03:45 -0400 Received: from mout.web.de ([212.227.15.4]:60429 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932123AbdEXRBW (ORCPT ); Wed, 24 May 2017 13:01:22 -0400 To: linux-mips@linux-mips.org, John Crispin , =?UTF-8?Q?Ralf_B=c3=a4chle?= Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] MIPS: ralink: Delete an error message for a failed memory allocation in rt_timer_probe() Message-ID: <0e1ec180-eb78-144f-03fa-2843efe57670@users.sourceforge.net> Date: Wed, 24 May 2017 19:01:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:WW5YcbjdBqny5XfQYzBpmIOgrkJj+YUPQkBEXn0G+zIq5LCSE6f KiZueR11Q7/JN9yP4xII4PDXhGrRK5+pq4GkHSjddf0/We3uI8zkxKQd5MMRGiQ4PPPY4RU 4e2+my89y5haris3/YbHxEXXMMlzNOxSN5G2oyZhAB3z/ajUhd7qExnfy/QvpKwRVoD+uBP HFYIXR4ZlQ4Vw7FHtTaHA== X-UI-Out-Filterresults: notjunk:1;V01:K0:h6siouhF2r0=:Zgm7bOcJzNlerF24DUEh9y HOVgB46EgTtmlyMREByYdcsQqeezFQMTZTVEkBJirETabPo8pWBK5mjswtGOQvqqO2Vv3wzi+ L9TaRG6e1vdw1sHSOEekunfJrEHs7v+FJ7RQl3NnccegpDmDX91UTRmOB8tfOHpYWk+SDU2nM qEThuCr4G5OhRf5wEYtb4ugYQYGpqDaQ4sai8FGN/sJJQmFAFKOEwHex0mSJQ23J2Um6IxZWh XmUVLd1gcsEgqQk4v1/Hu+unWlhZeP/BzQq4AyMRmJwz3iWUL391UjFjZMj9g2Py6WmJaiVjz XD+ZisJmj5kplxjdnsohxzibsx+hLsejbjjd7ZgCnQX8j7cNLLf+L1BEECfFFjeJAEDrB7mnp GNbDazN+tEnCV1OldtQk7v94jrvnYdneJDbQwRPLIpIUcSs7MtqGlJsy7FR4hGJIctztcIiTC yAI47DoeJWEet8yYxgU8I7KiJAIJIzIlnDMcLqd0DOJj616tpF4mwRMvwgRfHf4SeqfUm8+LM r3en97rXPrE6W1hBeFZDmbIVB3AQKD71sABAm32ssPLEUVO8pcWX5OcmWWy1ss71Wv1ytZO0Z glRxDBczPoWGKD0IsScII00wA72AT0vpFfqrXhrXrOhbuBtBl0q5UblcCj4hb9cXWA9KCFhhu Id2dJ8e0GgP1tgRntcaE/qD1BFbMbpyKWD0VQXXAVdrbQWy4VpwQ/62OgkpBbM5j5Zh3+/VJ5 MY5Z8gbp5fTssAUZW73RVvIJ6YN0/XhUp10WO+nGn+j49UnIhpdmPfOgfRKHloSJI7RrUJSCU nUkBUcm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 24 May 2017 18:56:35 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/mips/ralink/timer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c index d4469b20d176..efccb444d6bc 100644 --- a/arch/mips/ralink/timer.c +++ b/arch/mips/ralink/timer.c @@ -103,10 +103,8 @@ static int rt_timer_probe(struct platform_device *pdev) struct clk *clk; rt = devm_kzalloc(&pdev->dev, sizeof(*rt), GFP_KERNEL); - if (!rt) { - dev_err(&pdev->dev, "failed to allocate memory\n"); + if (!rt) return -ENOMEM; - } rt->irq = platform_get_irq(pdev, 0); if (!rt->irq) { -- 2.13.0