From: yumeng <yumeng18@huawei.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-crypto@vger.kernel.org>, <wangzhou1@hisilicon.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ecc: delete a useless function declaration
Date: Tue, 6 Apr 2021 09:12:40 +0800 [thread overview]
Message-ID: <0e272e6e-6cb0-2c03-86c3-08d54690c97e@huawei.com> (raw)
In-Reply-To: <3fbc88c4-50ae-3ffb-14e5-0cd39d492251@csgroup.eu>
在 2021/4/2 18:34, Christophe Leroy 写道:
>
>
> Le 02/04/2021 à 11:55, Meng Yu a écrit :
>> This function declaration has been added in 'ecc_curve.h',
>> delete it in 'crypto/ecc.h'.
>>
>> Fixes: 14bb76768275(crypto: ecc - expose ecc curves)
>
> Fixes tag is wrong I think, should be 4e6602916bc6
>
Yes, you are right, thank you.
>> Signed-off-by: Meng Yu <yumeng18@huawei.com>
>> ---
>> crypto/ecc.h | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/crypto/ecc.h b/crypto/ecc.h
>> index 46aa9bc..a006132 100644
>> --- a/crypto/ecc.h
>> +++ b/crypto/ecc.h
>> @@ -56,14 +56,6 @@ static inline void ecc_swap_digits(const u64 *in,
>> u64 *out, unsigned int ndigits
>> }
>> /**
>> - * ecc_get_curve() - Get a curve given its curve_id
>> - * @curve_id: Id of the curve
>> - *
>> - * Returns pointer to the curve data, NULL if curve is not available
>> - */
>> -const struct ecc_curve *ecc_get_curve(unsigned int curve_id);
>> -
>> -/**
>> * ecc_is_key_valid() - Validate a given ECDH private key
>> *
>> * @curve_id: id representing the curve to use
>>
> .
prev parent reply other threads:[~2021-04-06 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 9:55 Meng Yu
2021-04-02 10:34 ` Christophe Leroy
2021-04-06 1:12 ` yumeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e272e6e-6cb0-2c03-86c3-08d54690c97e@huawei.com \
--to=yumeng18@huawei.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®