mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"kartik.koolks@gmail.com" <kartik.koolks@gmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"kernel-usp@googlegroups.com" <kernel-usp@googlegroups.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"matheus.bernardino@usp.br" <matheus.bernardino@usp.br>
Subject: Re: [PATCH] staging:iio:adc:ad7280a: add of_match_table entry
Date: Fri, 26 Jul 2019 05:30:27 +0000	[thread overview]
Message-ID: <0e273486f1c4fb6249896225837cdf2da0fd2415.camel@analog.com> (raw)
In-Reply-To: <20190725200817.31277-1-kartik.koolks@gmail.com>

On Fri, 2019-07-26 at 01:38 +0530, Kartik Kulkarni wrote:
> Add the of_device_id struct and the respective
> of_match_device entry to complete device tree support.
> 

This would be a [V2] I suppose.

This change also does the rename of the driver name in a single go.
Since it's a trivial change, it's fine from my side.

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>


> Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
> Reviewed-by: Matheus Tavares <matheus.bernardino@usp.br>
> ---
>  drivers/staging/iio/adc/ad7280a.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 19a5f244dcae..ded0ba093a28 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -1027,9 +1027,16 @@ static const struct spi_device_id ad7280_id[] = {
>  };
>  MODULE_DEVICE_TABLE(spi, ad7280_id);
>  
> +static const struct of_device_id ad7280_of_match[] = {
> +	{ .compatible = "adi,ad7280a", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, ad7280_of_match);
> +
>  static struct spi_driver ad7280_driver = {
>  	.driver = {
> -		.name	= "ad7280",
> +		.name	= "ad7280a",
> +		.of_match_table = ad7280_of_match,
>  	},
>  	.probe		= ad7280_probe,
>  	.id_table	= ad7280_id,

  reply	other threads:[~2019-07-26  5:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 20:08 Kartik Kulkarni
2019-07-26  5:30 ` Ardelean, Alexandru [this message]
2019-07-26 17:59   ` Matheus Tavares Bernardino
2019-07-27 13:47     ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2019-07-25 20:06 Kartik Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e273486f1c4fb6249896225837cdf2da0fd2415.camel@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=StefanSerban.Popa@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=kartik.koolks@gmail.com \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matheus.bernardino@usp.br \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®