From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbeAIJtE (ORCPT + 1 other); Tue, 9 Jan 2018 04:49:04 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:43103 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752613AbeAIJs0 (ORCPT ); Tue, 9 Jan 2018 04:48:26 -0500 X-Google-Smtp-Source: ACJfBouh+q0M6KjPDaKAg2PDMnx+VSwd54BJ0l6R/xBU5B6iy5HYFiC/MVbFMOILzbTPuooX4u63Fg== Subject: Re: [PATCH 1/2] slimbus: qcom-ctrl: fix a NULL test To: Dan Carpenter , Sagar Dharia Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman References: <20180109092616.mfha2rs56oaxfjaz@mwanda> From: Srinivas Kandagatla Message-ID: <0e365f53-bb45-2d95-30fb-9a862319df35@linaro.org> Date: Tue, 9 Jan 2018 09:48:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180109092616.mfha2rs56oaxfjaz@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 09/01/18 09:26, Dan Carpenter wrote: > "retries" ends when it is set to -1 and not 0 so that part of the test > is wrong. This bug would lead to a NULL dereference a couple lines > later. > > Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework") > Signed-off-by: Dan Carpenter > --- > Should Greg be added to the MAINTAINERS file for this driver? > > diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c > index fb1a5e0eb8dd..3ab59209cbdc 100644 > --- a/drivers/slimbus/qcom-ctrl.c > +++ b/drivers/slimbus/qcom-ctrl.c > @@ -345,7 +345,7 @@ static int qcom_xfer_msg(struct slim_controller *sctrl, > } > } > > - if (!retries && !pbuf) > + if (!pbuf) > return -ENOMEM; > > puc = (u8 *)pbuf; > Already fixed at: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1575799.html