From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57CF732E6BC for ; Mon, 2 Mar 2026 08:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439067; cv=none; b=cyPJPD/OSos1UHOzHeHMR+jS3/vf2bHcmtfKjatt9eBOne9m1jHWeXZjiYej/KbjDtwdki4dVhBsfDK+bmQz56m+7SJwc7o3ZgBxzJmwGqacihOsOG/xwwQBsl9CnMVv6N570GXNe1qVqE4K1iMs/r8PMt4P4jz7lySI/cam5IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439067; c=relaxed/simple; bh=rv4MpTWLbVDrRZnGJ1y2PRJZKISGnzYKDx8X9nLiGok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XJu1owLISSDIxT9bmggOLhfuQGHBXZSvymnFnBLZGu7HJlANw6o4pWd6BZSskv0w4mmwS3lfujhbd/0d5tUuetrN8XlYOlcRWQe9FfKUbh8e3nT24GaPlj++Jm6qSXtOXa0YGo/z+p+MESjfAQiadts8CXoyn6rzs6kD1K/6quE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dLrAYbxi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YUzdmVDc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dLrAYbxi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YUzdmVDc" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62285X5s662196 for ; Mon, 2 Mar 2026 08:11:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bKT2lOHVdbNkn4L+PlCSmA7nngbFfRJNo82IaP0zHDw=; b=dLrAYbxiNF7vvyK6 SfLrKjq/5QhEdzKtiOGJpMAlUBmgBnsdvHRVnNL6SarLJwCyNmn2PP2Dw6paW7zr nYo8fH0aEF0W53Am0NrRUBvhOqD8oho/YUpKHCEjib21BnW14LFX8FbQNhx+SLtQ 53xSK6zvSZ7Q0xXzdi+75hhBBSjUD983ojc0cMzriV2YOs3fN20pqBvGMZnf58nL tXNEmLWU1FUMJZSSKbat+DF+Kzh8ZnPDXzhiW+BeJTPhi4KgX5SjXoyd012GKB0q S8h5N4QoyNJfPq+WrGMcR+Ut7+9zhun+dskiYvyshBjzsTjpwGzwNjJiWbJ8A7En vOa7zg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn6r2r0q9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 08:11:02 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ae59e057f1so2109775ad.1 for ; Mon, 02 Mar 2026 00:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772439061; x=1773043861; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bKT2lOHVdbNkn4L+PlCSmA7nngbFfRJNo82IaP0zHDw=; b=YUzdmVDcHDaTdRsugPWe6U4XegZJNXjdtHHkZDnOmIZxUlk4ekXzy7x3sD9pakWdvK Dvh8ka434zJxpIsgkyB86B66xQfa/u5aSDgVnVWm/Ery0NXcoQOcGrvA2mvKPAiDvcKG MfzVJLl1DA0z8/cnqYwBgoJu9s2fiXbInP3MKidhllF8cSpttUIhjLzjXyR6+g883/Hp rhZGw5pI5ffKEopkiZDgbGzFR6q9XeFKRptYI6gepj7S6ToY39NySSv5SnidTbfpE0OE 015OHO0lOsMkFgNLnR0ndCvmGNpZB3wga3JauWEgdlyRuRZkMDaqe8SIN042U2YaOwe/ l4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772439061; x=1773043861; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bKT2lOHVdbNkn4L+PlCSmA7nngbFfRJNo82IaP0zHDw=; b=j2Q02Eus9qpUvfds4ZhhXjS2CRQ7do6LhPbRZOjxtvU5dvxiwgN4uV3aWiPFfax+qO 10C9k6AjbmTZvNZN0643ck6MjQ7eSscANW4LucNPBzTofUwkY1l+PHtVmYaGDwMcSv5S PJvRgZA564XWsyf9ruHXU7/ygjDLrv3cjy8FYdYJPhu9VkDYonouZikViLx5GBx+zGP0 Rh9yHhfVkJTk0IqbxUfcu7aqExLvoub0VtHAQo7DvCJ0JY2E0zh40G9Nzvgi/wlFNTwg zleviouEQCBdytSQAhJ6jaV0jx50fQQLT4hCeF+2MlHbF4enizNhZRMnDqUGXO5c8gbH ogRA== X-Forwarded-Encrypted: i=1; AJvYcCW+bRV30UiXyratZjd+ymqamnAOUnhnbcPE3rAGURornvQ00uuf5x0qybrfKr5+V8BRVw3zzI2cCKiPaxo=@vger.kernel.org X-Gm-Message-State: AOJu0Yykp7Cul9TMcATEUmlGeFeP/jUd2Nj5Sk0ytOs+qyMYlPtybWSC 3PiHb8TKFvbuKPENpWU1VJt8kHYUlv95ccuLGtKtmG5mxcTr2b0HG+LJORa2uVh6KmTCpnXO8Vz J9NRZfw46kmikbnHmmda3mmVfImmg8Re0XasXnAZvt2HlTyZ+z+4spTamhGSmBzZNqCk= X-Gm-Gg: ATEYQzzQSOQAVC7AXnsoAB/bGTFQYFi6Op2OZk1x02+bPNGlKPzDOpefTtnwvGMTZCL MKbsZOoiOYWNhuiHLLz8Gq4DRjen5dfZZGvWkO/vOEtaufwkf741VJw2rI0SKhHEIfH4dhlUof/ AfMhHdTxRgK43xe2DfRbrfrKsA9E8hT3H4/dPapVCC01WqkJ6Tni0810elXPboEbMtzSVhcbuaH DGHIHNPi36A3vsBvcKQ86p3Yu9lXNOBp38U2tXnhtydETGMe+28Vo5VpsTLHgIv5662uamzN5yh ba47nsg8lj+LOsjG+vjlkJKani/HO/2WxHSVOFbLiBRdgsnZ5worgf7vAvuPo+CK2B/kmYMCBPw isXjKyV4pZX6ATNckhJhWqfHHMZ1cjHaoEiqzyBDtblDiSqZpbw== X-Received: by 2002:a17:902:ea02:b0:2ad:c527:e9fd with SMTP id d9443c01a7336-2ae2e4b5a34mr128338585ad.41.1772439061406; Mon, 02 Mar 2026 00:11:01 -0800 (PST) X-Received: by 2002:a17:902:ea02:b0:2ad:c527:e9fd with SMTP id d9443c01a7336-2ae2e4b5a34mr128338135ad.41.1772439060858; Mon, 02 Mar 2026 00:11:00 -0800 (PST) Received: from [10.206.99.28] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae45e07626sm51334055ad.39.2026.03.02.00.10.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 00:11:00 -0800 (PST) Message-ID: <0e38e009-8097-4a66-b04f-95468b731b6d@oss.qualcomm.com> Date: Mon, 2 Mar 2026 13:40:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 05/18] accel/qda: Create compute CB devices on QDA compute bus To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Bharath Kumar , Chenna Kesava Raju References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-5-fe46a9c1a046@oss.qualcomm.com> <57937a68-7f22-4ca1-8980-0be12cf06c66@oss.qualcomm.com> <3y6rn5ujkdbc6cd2ooq7gobjvokwwrey2xoj4d3h2pavi7r5k6@rrc6bbmutz73> Content-Language: en-US From: Ekansh Gupta In-Reply-To: <3y6rn5ujkdbc6cd2ooq7gobjvokwwrey2xoj4d3h2pavi7r5k6@rrc6bbmutz73> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Ny3JDCzsYxUTf-T4ErrGyACNJm5R63JZ X-Proofpoint-ORIG-GUID: Ny3JDCzsYxUTf-T4ErrGyACNJm5R63JZ X-Authority-Analysis: v=2.4 cv=Hpp72kTS c=1 sm=1 tr=0 ts=69a54616 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=ze67pjzAHjlU0Io9_bMA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA3MCBTYWx0ZWRfXxmbU1w3xqkv6 F5ef/CcoNukKQnSSFy3ACVzgcwCiHA4rILU/JgUt1Jm3AQVh7F/+Z4uiOD7KvOV4o3zWHYBDMpe IwXdZOWIlUBjBUpM4BFQ2ztDMd+s1MpQQZ2xvb1DgnBBU9i+nJ4Y/UezUZdLc7VQzDe1tWUCCBp Cpo6N5PDsFu6+5xssX+VLAM2slLLqlC0CXZ9Uy7NMMm1tr6WQHdM4Ab+7shW6YsLeFffsZRJzp9 JwN7nmoQNZJpjmmjLg1kqpjrOh/d6YfCgfR7EU1vKENK1FBxZ3IQCAwe7QIbr8z96vLebTlpbt8 xzwtjga7btSWTih3+z8jbIgs65uG2qN8x63w7Uklrt3dE3qwf3PSyrGDxktDQxWll7Xh7hAXA5g gKdxBrr0qzsSGUHF9JCXeoE3d1ajhzCybKR+nlXGxzo4ZvnFI5l9ddgJo08sM+dyyYiDm46CUDM P1jUotE3KXEpyLnKdRQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020070 On 2/26/2026 4:16 PM, Dmitry Baryshkov wrote: > On Thu, Feb 26, 2026 at 02:08:57PM +0530, Ekansh Gupta wrote: >> >> On 2/24/2026 4:19 AM, Dmitry Baryshkov wrote: >>> On Tue, Feb 24, 2026 at 12:38:59AM +0530, Ekansh Gupta wrote: >>>> Add support for creating compute context-bank (CB) devices under >>>> the QDA compute bus based on child nodes of the FastRPC RPMsg >>>> device tree node. Each DT child with compatible >>>> "qcom,fastrpc-compute-cb" is turned into a QDA-owned struct >>>> device on qda_cb_bus_type. >>>> >>>> A new qda_cb_dev structure and cb_devs list in qda_dev track these >>>> CB devices. qda_populate_child_devices() walks the DT children >>>> during QDA RPMsg probe, creates CB devices, configures their DMA >>>> and IOMMU settings using of_dma_configure(), and associates a SID >>>> from the "reg" property when present. >>>> >>>> On RPMsg remove, qda_unpopulate_child_devices() tears down all CB >>>> devices, removing them from their IOMMU groups if present and >>>> unregistering the devices. This prepares the ground for using CB >>>> devices as IOMMU endpoints for DSP compute workloads in later >>>> patches. >>> Are we loosing the nsessions support? >> Yes, it's not part of this series. I'll try bringing that as well. >>>> Signed-off-by: Ekansh Gupta >>>> --- >>>> drivers/accel/qda/Makefile | 1 + >>>> drivers/accel/qda/qda_cb.c | 150 ++++++++++++++++++++++++++++++++++++++++++ >>>> drivers/accel/qda/qda_cb.h | 26 ++++++++ >>>> drivers/accel/qda/qda_drv.h | 3 + >>>> drivers/accel/qda/qda_rpmsg.c | 40 +++++++++++ >>>> 5 files changed, 220 insertions(+) >>>> >>>> diff --git a/drivers/accel/qda/Makefile b/drivers/accel/qda/Makefile >>>> index 242684ef1af7..4aded20b6bc2 100644 >>>> --- a/drivers/accel/qda/Makefile >>>> +++ b/drivers/accel/qda/Makefile >>>> @@ -8,5 +8,6 @@ obj-$(CONFIG_DRM_ACCEL_QDA) := qda.o >>>> qda-y := \ >>>> qda_drv.o \ >>>> qda_rpmsg.o \ >>>> + qda_cb.o \ >>>> >>>> obj-$(CONFIG_DRM_ACCEL_QDA_COMPUTE_BUS) += qda_compute_bus.o >>>> diff --git a/drivers/accel/qda/qda_cb.c b/drivers/accel/qda/qda_cb.c >>>> new file mode 100644 >>>> index 000000000000..77a2d8cae076 >>>> --- /dev/null >>>> +++ b/drivers/accel/qda/qda_cb.c >>>> @@ -0,0 +1,150 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-only >>>> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include "qda_drv.h" >>>> +#include "qda_cb.h" >>>> + >>>> +static void qda_cb_dev_release(struct device *dev) >>>> +{ >>>> + kfree(dev); >>> Do you need to put the reference on the OF node? >> Reference put is happening as part of qda_destroy_cb_device. > This way: you have a (small) window where of_node is already put (and > might be gone), but the pointer is not NULL. The of_node should be put > only when device is no longer accessible from the rest of the system, in > release function. I'll move put to release function to avoid suggested scenario. Thanks. > >