From: Michal Simek <michal.simek@xilinx.com>
To: Rob Herring <robh@kernel.org>, Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
"Nava kishore Manne" <nava.manne@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
devicetree@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] char: xilinx_hwicap: Fix warnings in the driver
Date: Fri, 4 Aug 2017 09:49:33 +0200 [thread overview]
Message-ID: <0e40a687-e11b-b5bb-24f0-465144c98929@xilinx.com> (raw)
In-Reply-To: <20170803223218.ilryp5spqztsr3cz@rob-hp-laptop>
On 4.8.2017 00:32, Rob Herring wrote:
> On Fri, Jul 28, 2017 at 03:17:26PM +0200, Michal Simek wrote:
>> From: Nava kishore Manne <nava.manne@xilinx.com>
>>
>> This patch fixes the below warning
>> --> Use #include <linux/io.h> instead of <asm/io.h>
>> --> Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
>> --> please, no space before tabs
>> --> Block comments use a trailing */ on a separate line
>> --> Possible unnecessary 'out of memory' message
>> --> Block comments use * on subsequent lines
>> --> Block comments use a trailing */ on a separate line
>> --> braces {} are not necessary for any arm of this statement
>> --> DT compatible string "xlnx,opb-hwicap-1.00.b"
>> appears un-documented
>> --> DT compatible string "xlnx,xps-hwicap-1.00.a"
>> appears un-documented
>>
>> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Documentation/devicetree/bindings/xilinx.txt | 2 ++
>
> It's preferred to split bindings to separate patches. No need unless you
> respin:
>
> Acked-by: Rob Herring <robh@kernel.org>
thanks. Was there any outcome from that discussion to extract binding
out of kernel source code?
Thanks,
Michal
next prev parent reply other threads:[~2017-08-04 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:17 [PATCH 1/2] char: xilinx_hwicap: Fix kernel doc warnings Michal Simek
2017-07-28 13:17 ` [PATCH 2/2] char: xilinx_hwicap: Fix warnings in the driver Michal Simek
2017-08-03 22:32 ` Rob Herring
2017-08-04 7:49 ` Michal Simek [this message]
2017-08-10 18:16 ` Rob Herring
2017-08-11 12:31 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e40a687-e11b-b5bb-24f0-465144c98929@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=monstr@monstr.eu \
--cc=nava.manne@xilinx.com \
--cc=robh@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®