From: Dan Carpenter <error27@gmail.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH RESEND] sh: sq: Use the bitmap API when applicable
Date: Wed, 19 Apr 2023 07:48:08 +0300 [thread overview]
Message-ID: <0e420e0e-001e-4d0f-a192-a2daa4e789c6@kili.mountain> (raw)
In-Reply-To: <837e9f5e-ca8d-4c93-9a89-d7bdb9bb0240@kili.mountain>
On Tue, Apr 18, 2023 at 12:39:43PM +0300, Dan Carpenter wrote:
> On Tue, Apr 18, 2023 at 10:30:01AM +0300, Dan Carpenter wrote:
> > I have some unpublished Smatch stuff which tries to track "variable x
> > is in terms of bit units or byte units etc." I will try to make a
> > static checker rule for this.
>
> Attached. It prints a warning like this:
>
> drivers/net/ethernet/broadcom/cnic.c:667 cnic_init_id_tbl() warn: allocating units of longs instead of bytes 'test_var'
>
> I'll test it out tonight.
It didn't find any bugs. (Which is hardly surprising because most would
be caught in testing). No false postives either. I imagine that people
will introduce bugs like this in the future and now we'll see it when
that happens.
regards,
dan carpenter
prev parent reply other threads:[~2023-04-19 4:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 19:05 Christophe JAILLET
2023-04-16 19:33 ` John Paul Adrian Glaubitz
2023-04-17 6:51 ` Geert Uytterhoeven
2023-04-18 2:13 ` Rob Landley
2023-04-18 6:36 ` John Paul Adrian Glaubitz
2023-04-18 7:14 ` Geert Uytterhoeven
2023-04-18 7:18 ` John Paul Adrian Glaubitz
2023-04-18 18:05 ` Christophe JAILLET
2023-04-19 21:25 ` John Paul Adrian Glaubitz
2023-04-18 7:30 ` Dan Carpenter
2023-04-18 9:39 ` Dan Carpenter
2023-04-18 9:42 ` John Paul Adrian Glaubitz
2023-04-19 4:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e420e0e-001e-4d0f-a192-a2daa4e789c6@kili.mountain \
--to=error27@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®