From: Imran Khan <imran.f.khan@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: jiangshanlai@gmail.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, rafael@kernel.org, pavel@ucw.cz,
len.brown@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH v3] workqueue: Introduce show_one_worker_pool and show_one_workqueue.
Date: Wed, 20 Oct 2021 19:27:05 +1100 [thread overview]
Message-ID: <0e4601e4-5fb1-ba8c-71cb-41038b1e141f@oracle.com> (raw)
In-Reply-To: <YW8RYxb3rKGcD5mR@slm.duckdns.org>
Hi Tejun,
On 20/10/21 5:41 am, Tejun Heo wrote:
> On Sat, Oct 16, 2021 at 11:20:07AM +1100, Imran Khan wrote:
>> Currently show_workqueue_state shows the state of all workqueues and of
>> all worker pools. In certain cases we may need to dump state of only a
>> specific workqueue or worker pool. For example in destroy_workqueue we
>> only need to show state of the workqueue which is getting destroyed.
>>
>> So rename show_workqueue_state to show_all_workqueues(to signify it
>> dumps state of all busy workqueues) and divide it into more granular
>> functions (show_one_workqueue and show_one_worker_pool), that would show
>> states of individual workqueues and worker pools and can be used in
>> cases such as the one mentioned above.
>>
>> Also, as mentioned earlier, make destroy_workqueue dump data pertaining
>> to only the workqueue that is being destroyed and make user(s) of
>> earlier interface(show_workqueue_state), use new interface
>> (show_all_workqueues).
>>
>> Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
>
> Can you respin the patch on top of the following branch?
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-5.16
Sure, I have rebased it upon the suggested branch and have sent v4 [1]
of the change.
[1]
https://lore.kernel.org/lkml/20211020030900.321837-1-imran.f.khan@oracle.com/
Thanks,
--Imran
>
> Thank you.
>
prev parent reply other threads:[~2021-10-20 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 0:20 Imran Khan
2021-10-19 18:41 ` Tejun Heo
2021-10-20 8:27 ` Imran Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4601e4-5fb1-ba8c-71cb-41038b1e141f@oracle.com \
--to=imran.f.khan@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=jirislaby@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®