From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85DBC2040AD for ; Tue, 18 Mar 2025 08:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287452; cv=none; b=aCLKVaTnWnZtsAbQsw4soQq4T5MKyPHKrVJgxkNrQf9xRUjdrwa8+lwr3FYAO7WWkgcg/+EUSU9PovKHO2V/8dW8w6WJOfWt367Qd791QPenrqpq7mB0dbLAh9CHd3myCZyKnKQQsn+F3T1BfnYWi3o4ZxEbhin20+ivtGTtDtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287452; c=relaxed/simple; bh=fHxfR/Fe1vR2g75IQ8QN4VFEb1/+MPRV0zX5VIgT1+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kf4kUJ9xiDPEIUx+553C/RL81Frg189oPtAp/vDdkHoeA5+DM1KsreflF6Ld6RxI/oc6zu20PYnxwQilm9j+eMrx2/fcvtZMYaWQ/YrAvcGEFkBaUeZ7aSvYuzxVhbv16CIVtx2WJbIRGQXEKWq1CSEg/xUs9YM6wr9mUCfUfQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bxxwNmAk; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bxxwNmAk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742287449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HDmgZLLIpwK6kAQW08mjGUXvGaI9Zvm7zThuVW477Ug=; b=bxxwNmAkXgVa0mtK+eoRsSi+kmB417pvQXywEfWZU84UdYyqSe/0NmuLKtIaPMy56iymBk ezufvkqU3O55ve7wjkZq1pEDFtsUYDA6JD2kg6yHyz1ddF/FE/+FC1lIAcwoW03Rku3d5F rM003LzJ6BbSf/d1mfyJxr/j13ZWyt8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-8ziYHZT7PZ6u0WVUwtGDVA-1; Tue, 18 Mar 2025 04:44:06 -0400 X-MC-Unique: 8ziYHZT7PZ6u0WVUwtGDVA-1 X-Mimecast-MFC-AGG-ID: 8ziYHZT7PZ6u0WVUwtGDVA_1742287445 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39149cbc77dso3518219f8f.3 for ; Tue, 18 Mar 2025 01:44:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742287445; x=1742892245; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HDmgZLLIpwK6kAQW08mjGUXvGaI9Zvm7zThuVW477Ug=; b=BVoJxS9Y/7jXHpkjqPpzHYpl9mctAd6iLfoT5JB9UOruPrWXMFW21Eq0iyUuvNfvcO tx/bOQl2fvBjcWamXyf1rFqTdl4CciVfWdpsq79lvtAU/+9q3/ncF6MK6gXq8Jio7GTT Zvm40Wa5uDDEUj9f7hkAhZdDtVli5SWK3r7CApCoF5sm+IReqrLatbVfpSOnU5hbGtJ7 leApVcLyZJ0pyP8YQir4sr3r71phCVhN08pZYFNZDh69Rcf7frll0dA8slkrgf8v1Ixr 3TeUEGb/ene0vvszaWkb1Dc1j2jLgJxlv6C4Nnm5aSjsAx8yn3+Eu8OjvvE3vi5GUr6o 5hyA== X-Forwarded-Encrypted: i=1; AJvYcCWQzVhir1p3+hAtHDboDTQo6bVGIIAuUQWu2erPg8CYno5ABbhx11Uk/HsL3h1cmqnVDVUNV6syjzIWSPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwnDDW4qjWGj8SjceW8wakn/uXZvtAqZqCzMzrU5epnmRvuTZGL mH9AgUa/jU/oGFS9NWU/WxlCCKS/slLyWrltENIkxfHaHhCzSOCSumvAmnS6RNzpsWrcukD1j6F hlog6zgDk7YrwCzgRJ2O3qou+3NM7faa0DcmjqtszBR2cJD5cWd2aG3yWStSIBqXJTOdS7fDE X-Gm-Gg: ASbGncsHtA6kVt477jw5vE1MPmJU/+uLeAAiOA0b3/h+wnAbl81wlclxvNNa6MaZ67c PCUBF+Lo7K6cjktSg5c91wjHCY/uzWIeaGr8dtjf+IkMWWmeLPmzGHDzS5EWbc3ilDTS0DjFxy8 Epr+EctxQxBVAKeSFJg1fXclugR9jTlQN3igofNN87xKqJEalqWdUppCfxaFzNVecEdIUiVHUuV +nvU1F+felfZzcJmPEuAvZA+SLgRKHa0F4G0yMaxHXhF6UHKLCY7R3nzATgqlk+tgHWFQjzGaO9 Vsou9Evuo3u7eRQcbWBeUsXknetHTq7b3H03M66SL6gkV8IJVrMk7c4H9zudix11AY3c7LMBYIu LNfTsA1VEK7q18dPH7iSW9DYKCZMSWqz58D+la5Z6BK8= X-Received: by 2002:adf:a403:0:b0:390:e2a3:cb7b with SMTP id ffacd0b85a97d-3972029e76emr12128989f8f.34.1742287445227; Tue, 18 Mar 2025 01:44:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsMPDk30z1VcJpRB8YjodHuvxQ4d8je3JZS6Y7eZxfRI9LeTmUeExaG8tWg4CG2GeZC+ZVcg== X-Received: by 2002:adf:a403:0:b0:390:e2a3:cb7b with SMTP id ffacd0b85a97d-3972029e76emr12128962f8f.34.1742287444875; Tue, 18 Mar 2025 01:44:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c72d:2500:94b5:4b7d:ad4a:fd0b? (p200300cbc72d250094b54b7dad4afd0b.dip0.t-ipconnect.de. [2003:cb:c72d:2500:94b5:4b7d:ad4a:fd0b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c83b7656sm17079741f8f.40.2025.03.18.01.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 01:44:04 -0700 (PDT) Message-ID: <0e48e415-b5db-4555-b73b-d2a032752bfd@redhat.com> Date: Tue, 18 Mar 2025 09:44:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] fs/proc/page: Refactoring to reduce code duplication. To: Liu Ye , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev Cc: akpm@linux-foundation.org, willy@infradead.org, svetly.todorov@memverge.com, vbabka@suse.cz, ran.xiaokai@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Liu Ye References: <20250318063226.223284-1-liuyerd@163.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250318063226.223284-1-liuyerd@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18.03.25 07:32, Liu Ye wrote: > From: Liu Ye > > The function kpageflags_read and kpagecgroup_read is quite similar > to kpagecount_read. Consider refactoring common code into a helper > function to reduce code duplication. > > Signed-off-by: Liu Ye > > --- > V4 : Update code remake patch. > V3 : Add a stub for page_cgroup_ino and remove the #ifdef CONFIG_MEMCG. > V2 : Use an enumeration to indicate the operation to be performed > to avoid passing functions. > --- Acked-by: David Hildenbrand Thanks! -- Cheers, David / dhildenb