From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965243AbcJXUOV (ORCPT ); Mon, 24 Oct 2016 16:14:21 -0400 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:42031 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753826AbcJXUOS (ORCPT ); Mon, 24 Oct 2016 16:14:18 -0400 X-ME-Helo: [127.0.0.1] X-ME-Date: Mon, 24 Oct 2016 22:14:16 +0200 X-ME-IP: 92.140.170.6 Subject: Re: [PATCH] clk: keystone: Fix an error checking To: Lars-Peter Clausen , Dan Carpenter References: <20161023081249.24668-1-christophe.jaillet@wanadoo.fr> <20161024103614.GW4469@mwanda> <04b36f2d-69d5-110c-9ad8-a869a00ed2c9@metafoo.de> Cc: ssantosh@kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel.clk,gmane.linux.kernel,gmane.linux.kernel.janitors From: Christophe JAILLET Message-ID: <0e4dca9a-28f4-c8e2-836d-0cb2bded5d52@wanadoo.fr> Date: Mon, 24 Oct 2016 22:14:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <04b36f2d-69d5-110c-9ad8-a869a00ed2c9@metafoo.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 161024-1, 24/10/2016), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thanks for the review and comments. I'll send another patch for that. It will not be tagged as v2 because it will be part of a patch set for some other potential fixes. CJ Le 24/10/2016 à 12:41, Lars-Peter Clausen a écrit : > On 10/24/2016 12:36 PM, Dan Carpenter wrote: >> On Sun, Oct 23, 2016 at 10:12:49AM +0200, Christophe JAILLET wrote: >>> clk_register_pll() can return ERR_PTR(-ENOMEM) so here the check against >>> NULL only is not correct. >>> >> Change the ERR_PTR(-ENOMEM) to a NULL instead. > In this particular case propagate the error returned by clk_register(). > > -- > To unsubscribe from this list: send the line "unsubscribe linux-clk" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >