From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8716FC32771 for ; Wed, 28 Sep 2022 07:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233685AbiI1HfX (ORCPT ); Wed, 28 Sep 2022 03:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233684AbiI1HfL (ORCPT ); Wed, 28 Sep 2022 03:35:11 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41EB9D4A8A for ; Wed, 28 Sep 2022 00:34:55 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id a2so19079195lfb.6 for ; Wed, 28 Sep 2022 00:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=W84wrHvVvAgWhyh1WS/eLy6/o7Le2iFXNrohu7GUsCk=; b=NBAnH1KSEUqlchKnxRsgUvFEv9abO5xjXfHwbhygSEOQVMkUlrbPqLu4kzyW/v5vkT hf9Z/UL6un8qpptuEiDHQmkzduE+XekrebEoYp6CwU3pQJKQ7M0jx33VZbjgBeUHWUlO xqwQ9yoNjMehBIQhzakLFglLgdkpNM8LJy24ygJ964lTnbV/OzJJEKPdi0oy8esg5M9q S7JJXnwOrxJS438SXJcPp+wyiqg88B4HjbwO2OZQjQUu3hTzfxxMU5ehFmZmv30IOjaX xwBUIa6xYf32/K2WPRsKOKlejej5lml/aDenDWAtLAt1xcpRhp4I+E/HfzLRAwmn8nFk O3zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=W84wrHvVvAgWhyh1WS/eLy6/o7Le2iFXNrohu7GUsCk=; b=zVWPqHiQ10lyULpKVhXt0kPYVejPBdUJ22HpFEKlxohF8cCufdCawCGZY3rr7zLIB6 GKYElxvpAlLNXtbkBffKnQ8i3lUefqFbw3t5yfQJhNsIOg5X1i7PLde4bQ0etLi0edbG T3smR+n4LEQKgnszJ62jHl5cn8JVZy/kmaW86UhVN4yAjllOiiaS4HfmpC8Foi34io2D DlLdDtnjWeOuW/JVxw4ATT8HTnCOQRqlnniQT7rHidrtfMxsbqo+xDE81zQlIb/9yUCO Kk60S7Hrt+7YVpr6pB2tffOlcCRTw6AmmnNxi7EzO8vSQqWC56udsp3vAU5C7SHCuA0G 0uBQ== X-Gm-Message-State: ACrzQf0QZSHxsFYq6WeF8YyWqjI5oq6QXA14qj9mq4o46DPLlneXLFvI PVeDeMy1qhC+BU4bJjXReF+P6w== X-Google-Smtp-Source: AMsMyM4s9FD4pbLqo1tYHW7wHCeJO/EhwQuexdGfirp3jEWQdNrKBFwJ9RvGgx9b18FtcGBH/PMTlw== X-Received: by 2002:a05:6512:1325:b0:4a1:d80e:1cd5 with SMTP id x37-20020a056512132500b004a1d80e1cd5mr5194661lfu.497.1664350447109; Wed, 28 Sep 2022 00:34:07 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v9-20020a056512348900b0049465afdd38sm395786lfr.108.2022.09.28.00.34.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 00:34:06 -0700 (PDT) Message-ID: <0e53c7c8-e04c-5a87-9703-02748b64e491@linaro.org> Date: Wed, 28 Sep 2022 09:34:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 02/13] arm64: dts: rockchip: Add Hardkernel ODROID-M1 board Content-Language: en-US To: Aurelien Jarno , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" , open list Cc: Dongjin Kim References: <20220926183727.1893566-1-aurelien@aurel32.net> <20220926183727.1893566-3-aurelien@aurel32.net> From: Krzysztof Kozlowski In-Reply-To: <20220926183727.1893566-3-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/09/2022 20:37, Aurelien Jarno wrote: > From: Dongjin Kim > > This patch is to add a device tree for new board Hardkernel ODROID-M1 > based on Rockchip RK3568, includes basic peripherals - > uart/eMMC/uSD/i2c and on-board ethernet. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Dongjin Kim > [aurelien@aurel32.net: addressed issues from initial review] > Signed-off-by: Aurelien Jarno > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3568-odroid-m1.dts | 414 ++++++++++++++++++ > 2 files changed, 415 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index ef79a672804a..12e2ef73fe80 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -66,3 +66,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb Mismatched order. Best regards, Krzysztof