mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Li Jun <jun.li@nxp.com>, myungjoo.ham@samsung.com, cw00.choi@samsung.com
Cc: linux-kernel@vger.kernel.org, frank.li@nxp.com, xu.yang_2@nxp.com
Subject: Re: [PATCH v2 2/2] extcon: ptn5150: Add usb role class support
Date: Tue, 19 Apr 2022 10:35:09 +0200	[thread overview]
Message-ID: <0e569119-32e9-6549-d805-85f44fc5660e@linaro.org> (raw)
In-Reply-To: <1650354202-10445-2-git-send-email-jun.li@nxp.com>

On 19/04/2022 09:43, Li Jun wrote:
> Some usb controller drivers may not support extcon but use
> usb role class as it's the preferred approach, so to support
> usb dual role switch with usb role class, add usb role class
> consumer support.
> 
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> change for v2:
> - Add one patch to sync queue work before driver remove.
> - improve git commit log
> - use a variable of usb_role to set target role in
>   ptn5150_check_state() to simplify code.
> - use dev_err_probe for usb_role_switch_get() return value.
> 
>  drivers/extcon/Kconfig          |  1 +
>  drivers/extcon/extcon-ptn5150.c | 25 +++++++++++++++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index c69d40ae5619..f3352a81ee7c 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -130,6 +130,7 @@ config EXTCON_PTN5150
>  	tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
>  	depends on I2C && (GPIOLIB || COMPILE_TEST)
>  	select REGMAP_I2C
> +	select USB_ROLE_SWITCH

This is still being discussed. Rest looks good.

Best regards,
Krzysztof

  reply	other threads:[~2022-04-19  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19  7:43 [PATCH v2 1/2] extcon: ptn5150: add queue work sync before driver release Li Jun
2022-04-19  7:43 ` [PATCH v2 2/2] extcon: ptn5150: Add usb role class support Li Jun
2022-04-19  8:35   ` Krzysztof Kozlowski [this message]
2022-04-19  8:32 ` [PATCH v2 1/2] extcon: ptn5150: add queue work sync before driver release Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e569119-32e9-6549-d805-85f44fc5660e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=cw00.choi@samsung.com \
    --cc=frank.li@nxp.com \
    --cc=jun.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®