From: Mario Limonciello <mario.limonciello@amd.com>
To: Vyacheslav Frantsishko <itmymaill@gmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
broonie@kernel.org
Cc: perex@perex.cz, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA
Date: Wed, 26 Jun 2024 00:55:16 -0500 [thread overview]
Message-ID: <0e571211-8921-4548-a093-6c5719c866c4@amd.com> (raw)
In-Reply-To: <20240626055131.44014-1-itmymaill@gmail.com>
On 6/26/2024 00:51, Vyacheslav Frantsishko wrote:
> Signed-off-by: Vyacheslav Frantsishko <itmymaill@gmail.com>
>
> The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.
> ---
This is a Ryzen 6000 (YC) product, so this does look like the right
solution.
Your SoB tag is in the wrong place (should be at end of commit message),
not sure if ALSA guys can fix that while committing or you need to
re-submit.
But the content looks fine to me otherwise.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 1760b5d42460..4e3a8ce690a4 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
> }
> },
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
next prev parent reply other threads:[~2024-06-26 5:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 5:51 Vyacheslav Frantsishko
2024-06-26 5:55 ` Mario Limonciello [this message]
2024-06-26 7:03 ` Vyacheslav Frantsishko
2024-06-26 12:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e571211-8921-4548-a093-6c5719c866c4@amd.com \
--to=mario.limonciello@amd.com \
--cc=broonie@kernel.org \
--cc=itmymaill@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®