From: Michal Simek <monstr@monstr.eu>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] microblaze: fix cleaning of boot images
Date: Wed, 5 Dec 2018 16:41:13 +0100 [thread overview]
Message-ID: <0e57c216-c85c-9cd4-7922-e4509e44858c@monstr.eu> (raw)
In-Reply-To: <1543823457-32478-2-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1.1: Type: text/plain, Size: 1511 bytes --]
On 03. 12. 18 8:50, Masahiro Yamada wrote:
> The simpleImage.<dt> target generates the following files:
>
> arch/microblaze/boot/simpleImage.<dt>
> arch/microblaze/boot/simpleImage.<dt>.ub
> arch/microblaze/boot/simpleImage.<dt>.strip
> arch/microblaze/boot/simpleImage.<dt>.unstrip
>
> However, "make ARCH=microblaze clean" only cleans up the unstrip
> image. Fix the clean-files to take care of all the four.
>
> Adding linux.bin.ub to clean-files is redundant because it is
> already added into "targets".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/microblaze/boot/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
> index 600e5a1..e8684a2 100644
> --- a/arch/microblaze/boot/Makefile
> +++ b/arch/microblaze/boot/Makefile
> @@ -37,4 +37,4 @@ $(obj)/simpleImage.%: vmlinux FORCE
> $(call if_changed,strip,.strip)
> @echo 'Kernel: $(UIMAGE_OUT) is ready' ' (#'`cat .version`')'
>
> -clean-files += simpleImage.*.unstrip linux.bin.ub
> +clean-files += simpleImage.*
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2018-12-05 15:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 7:50 [PATCH 0/7] microblaze: fix various problems in building " Masahiro Yamada
2018-12-03 7:50 ` [PATCH 1/7] microblaze: fix cleaning of " Masahiro Yamada
2018-12-05 15:41 ` Michal Simek [this message]
2018-12-03 7:50 ` [PATCH 2/7] microblaze: adjust the help to the real behavior Masahiro Yamada
2018-12-05 15:40 ` Michal Simek
2018-12-06 5:27 ` Masahiro Yamada
2018-12-06 12:52 ` Michal Simek
2018-12-07 9:50 ` Masahiro Yamada
2018-12-07 10:21 ` Masahiro Yamada
2018-12-07 10:47 ` Michal Simek
2018-12-03 7:50 ` [PATCH 3/7] microblaze: move "... is ready" message to arch/microblaze/Makefile Masahiro Yamada
2018-12-05 15:47 ` Michal Simek
2018-12-03 7:50 ` [PATCH 4/7] microblaze: fix multiple bugs in arch/microblaze/boot/Makefile Masahiro Yamada
2018-12-05 15:57 ` Michal Simek
2018-12-03 7:50 ` [PATCH 5/7] microblaze: add linux.bin* and simpleImage.* to PHONY Masahiro Yamada
2018-12-05 15:59 ` Michal Simek
2018-12-03 7:50 ` [PATCH 6/7] microblaze: fix race condition in building boot images Masahiro Yamada
2018-12-05 16:31 ` Michal Simek
2018-12-08 6:51 ` Masahiro Yamada
2018-12-03 7:50 ` [PATCH 7/7] microblaze: remove the unneeded code just in case file copy fails Masahiro Yamada
2018-12-05 16:33 ` Michal Simek
2018-12-05 16:41 ` [PATCH 0/7] microblaze: fix various problems in building boot images Michal Simek
2018-12-06 5:08 ` Masahiro Yamada
2018-12-06 13:09 ` Michal Simek
2018-12-07 11:25 ` Masahiro Yamada
2018-12-06 14:44 ` Michal Simek
2018-12-07 11:29 ` Masahiro Yamada
2018-12-07 13:29 ` Michal Simek
2018-12-07 15:19 ` Michal Simek
2018-12-08 6:14 ` Masahiro Yamada
2018-12-12 13:50 ` Michal Simek
2018-12-12 14:11 ` Masahiro Yamada
2018-12-12 14:21 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e57c216-c85c-9cd4-7922-e4509e44858c@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®