From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03D332FE04D for ; Mon, 22 Dec 2025 19:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766432198; cv=none; b=l9HHIU+jMXlpCYu2Or+gvd8DLqP5ltHuKlMXrUJxNt9u6mTsoSBZWnuRelTqM3eI56Er4LPWthqgfCB/JqfOzs1OhLGgezXnCI/+OTXOfUIKR9NoH3viieKEzel4EwSEMPGTy4fGvjQPMtt04zHd/WXjjE6Iazqc2fvrkN8XwUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766432198; c=relaxed/simple; bh=hFP8wNqan67bFKWAJvdODGqeW6LGRWIvu/1ZkhiDoGY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k8j1C0GNyw/eC++aL6THtP5q86foGTsuocm8Sfi2NWVuYpvh2NqoRJLSMzGz692JT02W4AwRabSdV0QZ6FECMJ5CREiaijKd6XqdFbcuzSAraRx92tRXcKL8MmFCwUT9nf0AY2tameB7sjx2yHKEilReWIw8PYbJGjpJL6GE0KM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jQrwaqUR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kiPrOeAX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jQrwaqUR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kiPrOeAX" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BMFkx3p1356377 for ; Mon, 22 Dec 2025 19:36:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nn+s1homNWQHMLWddz1S2iuslw+Ts3/5yDOH/7TAz+o=; b=jQrwaqURDpMYcJ+g BSunj32sgTKzILCDPr2RUtA4nv6oA7xkzmsMN+BKPJNV6N07ytkTm8Kz3v2lPa2B +8ltcFOGUHtdEGMAeHKwQTs8qV1PiyuovZX6PsakWAYFBkLXMbFbtzlGPSQ38sAs Sfoj4UOQwWOYuNOKGCzxSNQkspht5lCyRUzgQ7F2t7gb70mPhd3KLTai+KEqRFyV mma7EZQEKqxao53EY7li/mjqxtjycMv/nNL4n1MlCuCg5PMNvBEvbfXa4g9YnK8M BH+8wzVbmTCuRMplFVyjal8/5Oe6WzbJSiZ+0QvxROLrL5VpJJ1BBzUpXW/HyGeV h0trww== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b78xc0hrf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 19:36:35 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7d24bbb9278so8434716b3a.0 for ; Mon, 22 Dec 2025 11:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766432195; x=1767036995; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nn+s1homNWQHMLWddz1S2iuslw+Ts3/5yDOH/7TAz+o=; b=kiPrOeAXjBxDjNDBypWt9uFG6KZ0kerbKqkZO01aFdpyyArLLFk8NtBuC/wV0xsFov yWqBdL1hSVrqMS6jfTxqxfZOdm8Ufyja1OWfqB38Bo5WzU1ee1MRMS/V4NBC46a3PUkh 22LW6VvY6LvCX1niBrTPdbMHi7VNUh0BMEXmbAr1G3+78dOeKhdq6GHDWirRhKOBkghv M9T0aTgvF01NMpyygtkP/LUeLzJtEv+E21Axv43HfSIO3QKzq2PPfN/eyq+SSc2YS5+a TGM6HOdvuxFCS5MlElVa6uXBr/mJNjnH213riSXjns0pSCgX6YLhN78G/MBp/wz1Qk9J 1zkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766432195; x=1767036995; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nn+s1homNWQHMLWddz1S2iuslw+Ts3/5yDOH/7TAz+o=; b=jdjxaKW9frz74lBbfZfPjHrJkc5XqIsjguq65zEkyl5pZ6yCBtLx+cU4xs1MDucSmG JWSZBCF1E/PG5zqOsfnEJDeiV8kUp1bLIM3inX9kPDUWrQGPTH8D25txlo8AYW5TszCP 9+o4o+on79giLA6LgSe6XPq7qQnQa2plFgc+6JVOjWq31TQB5M75NJmGhh9QFMT00NtL 9VCmEVrCf9DQhT0dOUcQhYA3MQvqblX8nzr1MOnqnnKan9ONd0h9fUQLQrYcFWUMkncC YH1npEVjBBp91IS/o8KD2fDlQ0e8qfgKgnprq8Es5Q30qAhliMr79lEhthOdg0NIirOx +GuQ== X-Forwarded-Encrypted: i=1; AJvYcCVHFGuVuqmwSKbHjN3CzkLIf/xpmsTzmpmUk3NZRfffgpbTC3dM562EJlKVNFZxB2HeYI9UFG32JNNcF4k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+s4a7r40RdoVXAzsR1vYLuYQF/qdBtjSHETEvy1TCs1oBD1Sz XDj2BNplAAMc6li0HG6Rw5gJThT5Pgx/ribApskbuijiWteidG1zvf8JmgNTCXKYApRZGBuRxZ0 Wtcn0220ULiPRLKLePguKsroLvd+zJs6BIZV3M0f8raAlnY7rWzoqdAtKfPVYFuB/mL8= X-Gm-Gg: AY/fxX4kVVXk4fAAFbyTc89E6vLZ6RB2GOKzhvR8T+VWEo6E+HtZy0smjsyJp6f+iI4 NgexmHucq3XUXA6ps4MgvYz0wM1qDj8MWrBTaqdcvRqicmJaH4nFGdkBAk/eiNdTJdx3YxG7A9Z 69Yh5MOyUaQH4novzOst3o2hbac/eV5D9JrkTgtacKBwI/KcsMkQ9FUPPu+2nCpNjY21i88pTBP DJjMZcZNUSwYxFkB9fVTawOCPs/uO0O+k5m3VHV0wC0gLV0xXJAcIVHMNNPoH+lElHtixiO4p2d jD+t060HnGKFDM4L7TQEhpZ7KECW+quPlMs236ROdDNpNI5LXA4AL5cFqEWs/a4Ue0tpy+AcCRu ap9ygshPe2EsiwrSJ6+rbPgSBVNoAwvT92g== X-Received: by 2002:a05:6a00:4105:b0:7b2:2d85:ae74 with SMTP id d2e1a72fcca58-7ff65d7e724mr10088523b3a.29.1766432194765; Mon, 22 Dec 2025 11:36:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYTrKbRHCEjE4Of6gK0jRIFuxMxi8T8wLXlsDgiw9a+p7RRCcbDeWEWpFFi4cgP/vYgY1lxw== X-Received: by 2002:a05:6a00:4105:b0:7b2:2d85:ae74 with SMTP id d2e1a72fcca58-7ff65d7e724mr10088499b3a.29.1766432194320; Mon, 22 Dec 2025 11:36:34 -0800 (PST) Received: from [192.168.1.5] ([106.222.228.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e48e1d6sm8647579b3a.53.2025.12.22.11.36.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 11:36:34 -0800 (PST) Message-ID: <0e592574-9e8f-4bb0-b875-3a437fd340fb@oss.qualcomm.com> Date: Tue, 23 Dec 2025 01:06:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/a6xx: fix bogus hwcg register updates To: Johan Hovold , Rob Clark , Sean Paul Cc: Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20251221164552.19990-1-johan@kernel.org> Content-Language: en-US From: Akhil P Oommen In-Reply-To: <20251221164552.19990-1-johan@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 90zpYdrt7h-GxtB4DS8myIyKGXJvZEQC X-Proofpoint-ORIG-GUID: 90zpYdrt7h-GxtB4DS8myIyKGXJvZEQC X-Authority-Analysis: v=2.4 cv=cuKWUl4i c=1 sm=1 tr=0 ts=69499dc3 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=oy5nMm26i85I/VS19bmskg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=dk0i7xQ4PQfej7aG6gsA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDE3OSBTYWx0ZWRfX49hme5gThcUS BA42td8H/oEqSPzbHsz/FXGxyk1M5LfR9WlZ7/FcWE4j6F7S9tkptdP7PilwOwBZ+mTQNfzm4xP B+bSdPF0zDJvlO/SIvrUO1/7cIC6amMgIQI5uddWUubMwtL/xZAOrAep6tiHNd9Ztkxy6UHzx/U xE84DIIuORLi2iSq4/WTq6N3qnAh65jOcIbuNZJrU9QoHQ5G8uhQQLvbQpihpqGFCLFzojQJnYi llCqhS+x4oj/fWR4fCXx36sI3Z+4kk5mfGBzijr/Qznm6DunDXtTtfb3gobqrWN+6Zs5edKqHdz ehAIzBOzRD+CFZLmyRsFWwthq4ROwet5ME+thaVikool/Hvjt1zj94yuXJAVkW4KYIQFoTtETXR 4bJ5ezF1NrCsKonVCNSvy/Wzb8u8/OhB9ou/3VAfkWmIydav9OWiR0UMLywpkWQetxnYgWw0qtj 2ScanvTGbEE5L8MAnhA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-22_03,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220179 On 12/21/2025 10:15 PM, Johan Hovold wrote: > The hw clock gating register sequence consists of register value pairs > that are written to the GPU during initialisation. > > The a690 hwcg sequence has two GMU registers in it that used to amount > to random writes in the GPU mapping, but since commit 188db3d7fe66 > ("drm/msm/a6xx: Rebase GMU register offsets") they trigger a fault as > the updated offsets now lie outside the mapping. This in turn breaks > boot of machines like the Lenovo ThinkPad X13s. > > Note that the updates of these GMU registers is already taken care of > properly since commit 40c297eb245b ("drm/msm/a6xx: Set GMU CGC > properties on a6xx too"), but for some reason these two entries were > left in the table. > > Fixes: 5e7665b5e484 ("drm/msm/adreno: Add Adreno A690 support") > Cc: stable@vger.kernel.org # 6.5 > Cc: Bjorn Andersson > Cc: Konrad Dybcio > Signed-off-by: Johan Hovold Reviewed-by: Akhil P Oommen I fixed a similar out of bound access issue in the coredump path last month. This pattern indicates that we should consider combining the IO accessors of both gpu and gmu. -Akhil > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > index 29107b362346..4c2f739ee9b7 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > @@ -501,8 +501,6 @@ static const struct adreno_reglist a690_hwcg[] = { > {REG_A6XX_RBBM_CLOCK_CNTL_GMU_GX, 0x00000222}, > {REG_A6XX_RBBM_CLOCK_DELAY_GMU_GX, 0x00000111}, > {REG_A6XX_RBBM_CLOCK_HYST_GMU_GX, 0x00000555}, > - {REG_A6XX_GPU_GMU_AO_GMU_CGC_DELAY_CNTL, 0x10111}, > - {REG_A6XX_GPU_GMU_AO_GMU_CGC_HYST_CNTL, 0x5555}, > {} > }; >