From: Eric Dumazet <eric.dumazet@gmail.com>
To: Lawrence Brakmo <brakmo@fb.com>,
"Tilmans,
Olivier (Nokia - BE/Antwerp)"
<olivier.tilmans@nokia-bell-labs.com>,
David Miller <davem@davemloft.net>
Cc: "De Schepper,
Koen (Nokia - BE/Antwerp)"
<koen.de_schepper@nokia-bell-labs.com>,
"research@bobbriscoe.net" <research@bobbriscoe.net>,
"fw@strlen.de" <fw@strlen.de>,
"borkmann@iogearbox.net" <borkmann@iogearbox.net>,
"ycheng@google.com" <ycheng@google.com>,
"ncardwell@google.com" <ncardwell@google.com>,
"edumazet@google.com" <edumazet@google.com>,
"agshew@gmail.com" <agshew@gmail.com>,
"glenn.judd@morganstanley.com" <glenn.judd@morganstanley.com>,
"kuznet@ms2.inr.ac.ru" <kuznet@ms2.inr.ac.ru>,
"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses
Date: Fri, 5 Apr 2019 02:23:41 -0700 [thread overview]
Message-ID: <0e5b047e-8ee1-ee53-cd46-3be70f0d618f@gmail.com> (raw)
In-Reply-To: <75CDFF88-5632-4A44-A2BF-5725CDDE7DCA@fb.com>
On 04/04/2019 11:55 AM, Lawrence Brakmo wrote:
>
> The module parameter, even if enabled by default, would have been
> preferable since it would support environments where this feature
> turned out to be sub-optimal.
Module parameters are awful, just add a sysctl if you need.
Bonus : per netns thing, meaning writing tests (say with packetdrill) is easier,
since you can launch dozens of them in parallel, each one in a different netns.
prev parent reply other threads:[~2019-04-05 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 12:24 Tilmans, Olivier (Nokia - BE/Antwerp)
2019-04-04 13:17 ` Florian Westphal
2019-04-04 13:48 ` Neal Cardwell
2019-04-04 13:55 ` Neal Cardwell
2019-04-04 13:59 ` Daniel Borkmann
2019-04-04 17:52 ` David Miller
2019-04-04 18:10 ` Lawrence Brakmo
2019-04-04 18:39 ` Tilmans, Olivier (Nokia - BE/Antwerp)
2019-04-04 18:55 ` Lawrence Brakmo
2019-04-05 9:23 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e5b047e-8ee1-ee53-cd46-3be70f0d618f@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=agshew@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=brakmo@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=glenn.judd@morganstanley.com \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.tilmans@nokia-bell-labs.com \
--cc=research@bobbriscoe.net \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome