From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B2DC433DB for ; Mon, 22 Feb 2021 19:20:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 226C564E12 for ; Mon, 22 Feb 2021 19:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232981AbhBVTTT (ORCPT ); Mon, 22 Feb 2021 14:19:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232888AbhBVTOS (ORCPT ); Mon, 22 Feb 2021 14:14:18 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECAAC061356 for ; Mon, 22 Feb 2021 11:12:50 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id i9so259883wml.5 for ; Mon, 22 Feb 2021 11:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8R2nhedFMBS0Evz/oU72XEbm/1TReocnZGcamPRVP1g=; b=PmrT5HrV+fQlRSeimNblYdmPwTIB7+QbCBnQ9PPV26gjLmFV34aw6iLtNoL2AIZE4d 3mgj74vk+P5CPNXlZZHA5+WSZ8QI2XSIoDp+ev0YlAv0FdmsZv+KJHpDK8lm6jpYMdIr BkJThbQT/sNbmugmQHsF0eORG9vTDIcEo4nFT5Aidcw1WdkX7c6bREKXdQZtROIRooMT yrKmgxlRxVDlphH2dJVf51W93fDrMhYsznZtTo0Z5MI0Jgkx0SPMrx5+EEIUqlt9fJQq nRL5UItgtusjNKgl/lUWtL5WC6lxKEXf2TtxYWpLbWwdrOI42mTd0C9iX54jWCWhzFp6 8/Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8R2nhedFMBS0Evz/oU72XEbm/1TReocnZGcamPRVP1g=; b=hMXWe/UphNj9n4n86B1VwIy72hZQn8x8DOd/1Z3zTIdaJL0r05jdJHlhVzGy9bPJVp XoERWsDUDDazqNG7089eNZh8Bk/AcGTGg+f9HHS8VnIjg/8dTLcCLzkEa78IURS10K9W giOIOioYSrM0aw7115ElZu88p4ubJSmtBvR7xxvGFwN2INGGsKSdF/k6wksZ94HGQPu8 U+q9ZqQwH89BriMsTYkhdqerrnrqq7zmrFLTL+0dP6wdjByd7Y3bGZEuQ/7Ix+1KHjhQ /nAqXCAtgg1/VtdBNrin5bxuU21rGQuTVXwKp1/cr7pO/fn+7PgaJrIvPXF43CuRPngJ l6jw== X-Gm-Message-State: AOAM530YjPbNYYacmdJDq3dLltQGWvLNlhrRFNBv3CCHbi4ftbEnq9p5 6Rk1UhY02rD7BTCV9Dz/zlyyrw== X-Google-Smtp-Source: ABdhPJySNOsw6p+WnFtTBSJswZjYlpQht23XuomeLaPvabdFFun76t06rZ+ctqF96HKM/J/wzaSwBg== X-Received: by 2002:a1c:4d0d:: with SMTP id o13mr4893612wmh.147.1614021169161; Mon, 22 Feb 2021 11:12:49 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:246c:9c33:7c45:77cd? ([2a01:e34:ed2f:f020:246c:9c33:7c45:77cd]) by smtp.googlemail.com with ESMTPSA id m184sm264439wmf.15.2021.02.22.11.12.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Feb 2021 11:12:48 -0800 (PST) Subject: Re: [GIT PULL] thermal for v5.12-rc1 To: Linus Torvalds Cc: Zhang Rui , Kai-Heng Feng , Lukasz Luba , Arnd Bergmann , Tony Lindgren , Dmitry Baryshkov , Colin King , Viresh Kumar , Linux Kernel Mailing List , Linux PM mailing list References: From: Daniel Lezcano Message-ID: <0e61a669-129e-b223-644a-33da100e6d5e@linaro.org> Date: Mon, 22 Feb 2021 20:12:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 22/02/2021 18:44, Linus Torvalds wrote: > On Fri, Feb 19, 2021 at 3:54 AM Daniel Lezcano > wrote: >> >> Note a set of changes for the qcom adc driver rely on an immutable >> branch from the iio tree: > > That part is fine, but what _isn't_ great is the merge commit message. > > This is the message in its entirety: > > "Merge remote-tracking branch > 'iio-thermal-5.11-rc1/ib-iio-thermal-5.11-rc1' into testing" > > Notice how it doesn't say _anything_ useful. > > Merges are commits, and they should have commit messages with > *explanation* the same way all regular commits should. In fact, they > generally should have *more* explanation, since they are fundamentally > more interesting and subtle than some one-liner obvious bug-fix. > > So this all looks otherwise fine, and I like how you were clearly > aware of the whole cross-tree merge, and how you let me kn0ow about > it. I appreciate that part, and I've pulled your branch. > > But I wanted to really take this moment to point out that merge > commits really should have messages explaining *why* and *what* got > merged. Not just the technical "I merged that tree". Thanks for pointing this out, I will take care in the future to give a better description. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog