From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Nguyen Ngoc Thang <ngocthang2710.1999@gmail.com>,
Harry Yoo <harry@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Hao Li <hao.li@linux.dev>, Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Suren Baghdasaryan <surenb@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzbot+527fed49e5b988882c9a@syzkaller.appspotmail.com,
Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH] mm/slub: don't let kmemleak report rcu sheaves
Date: Mon, 16 Nov 2026 11:54:37 +0100 [thread overview]
Message-ID: <0e626675-c6f9-40d7-a4ae-de069154ada2@kernel.org> (raw)
In-Reply-To: <20261113151837.123795-1-ngocthang2710.1999@gmail.com>
+CC Breno
On 11/13/26 16:18, Nguyen Ngoc Thang wrote:
> kmemleak reports full rcu sheaves as leaked:
>
> unreferenced object 0xffff88810005f600 (size 512):
> hex dump (first 32 bytes):
> e0 79 f0 2b 81 88 ff ff 20 00 b4 81 ff ff ff ff
> 00 12 04 00 81 88 ff ff 3c 00 00 00 00 00 00 00
> backtrace:
> __alloc_empty_sheaf mm/slub.c:2854 [inline]
> alloc_empty_sheaf mm/slub.c:2874 [inline]
> __pcs_replace_empty_main+0x260/0x2e0 mm/slub.c:4806
>
> The second word is rcu_free_sheaf and the size equals the capacity: the
> sheaf was handed to call_rcu() by __kfree_rcu_sheaf() and is waiting for
> a grace period. At that point the only reference to it is the ->next
> pointer of the previous callback in the rcu callback list.
>
> That previous callback may live in memory kmemleak never scans, e.g. the
> rcu_head of a struct slab queued by rcu_free_slab() for a
> SLAB_TYPESAFE_BY_RCU cache. Slab pages are frozen (page_count() == 0),
> so kmemleak skips their struct page. The chain from rcu_data is cut and
> the sheaf, typically allocated long ago and recycled, looks unreferenced.
> Since the sheaf is then not scanned either, the objects it is about to
> free can be reported as well.
I don't get this part. The previous object can't be that much gone, RCU
still needs to get to this sheaf at some point, so there has to be a live
pointer somewhere?
> Sheaves are allocator metadata and are always owned by a pcs, a barn or
> an rcu callback. Mark them with kmemleak_not_leak(): they are never
> reported but still scanned, so objects queued in them stay referenced.
> Allocations that can't spin are not tracked by kmemleak, so skip them,
> as alloc_slab_obj_exts() does.
>
> Fixes: ec66e0d59952 ("slab: add sheaf support for batching kfree_rcu() operations")
> Reported-by: syzbot+527fed49e5b988882c9a@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=527fed49e5b988882c9a
> Signed-off-by: Nguyen Ngoc Thang <ngocthang2710.1999@gmail.com>
I wonder if we should rather do this at the moment the sheaf is handed over
to rcu.
Or if it's a generic problem that should rather be solved by kmemleak having
visibility to the rcu queues.
> ---
> Reproduced in QEMU (syzbot config, 2 vCPUs, numa=fake=2) by stalling a
> grace period with a preempted reader on CPU0 while CPU1 interleaves
> rcu_free_slab() (filp slabs) and rcu_free_sheaf() (maple nodes freed by
> kfree_rcu()) callbacks, then running two kmemleak scans:
>
> before: 16-18 sheaves reported per run, rcu_head.func == rcu_free_sheaf,
> plus maple nodes held by them
> after: no sheaf or maple node reports, no new warnings
>
> mm/slub.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index cd671b934719..e01416ae0b4a 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2856,6 +2856,14 @@ static struct slab_sheaf *__alloc_empty_sheaf(struct kmem_cache *s, gfp_t gfp,
> if (unlikely(!sheaf))
> return NULL;
>
> + /*
> + * A queued rcu sheaf may only be referenced by an earlier rcu callback
> + * in memory kmemleak doesn't scan (e.g. struct slab). Never report
> + * sheaves, but keep scanning the objects they hold.
> + */
> + if (alloc_flags_allow_spinning(alloc_flags))
> + kmemleak_not_leak(sheaf);
> +
> sheaf->cache = s;
>
> stat(s, SHEAF_ALLOC);
prev parent reply other threads:[~2026-11-16 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 15:18 Nguyen Ngoc Thang
2026-11-16 10:54 ` Vlastimil Babka (SUSE) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e626675-c6f9-40d7-a4ae-de069154ada2@kernel.org \
--to=vbabka@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=cl@gentwo.org \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngocthang2710.1999@gmail.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=surenb@google.com \
--cc=syzbot+527fed49e5b988882c9a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®