From: Steven Price <steven.price@arm.com>
To: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] drm/panfrost: Avoid user size passed to kvmalloc()
Date: Fri, 17 Dec 2021 08:56:01 +0000 [thread overview]
Message-ID: <0e62a011-ef0a-fa04-664e-a70e5dd49cf2@arm.com> (raw)
In-Reply-To: <Ybt8QWEAooP++R7a@maud>
On 16/12/2021 17:49, Alyssa Rosenzweig wrote:
>> This provides an easy method for user
>> space to trigger the OOM killer (by temporarily allocating large amounts
>> of kernel memory)
>
> panfrost user space has a lot of easy ways to trigger to the OOM killer
> unfortunately .... if this is something we want to fix there are a lot
> more patches coming :(
>
Sorry I should have been a bit clearer in my wording. The issue isn't
triggering the OOM killer as such - it's triggering the OOM killer
without allocating memory accounted to the process. So e.g. allocating
large numbers of BOs should be ok as the OOM killer will come for the
process that allocated those BOs (so this is not much different from
allocating normal user space memory). However in this path there's no
user space allocation - so we can have a tiny process that triggers a
large kernel allocation and the OOM killer will go after every other
process first.
As Dan points out syzbot can have fun with this sort of thing (if it can
figure out the ioctl).
Thanks,
Steve
prev parent reply other threads:[~2021-12-17 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 16:16 Steven Price
2021-12-16 17:12 ` Rob Herring
2021-12-17 8:55 ` Steven Price
2021-12-17 9:10 ` Dan Carpenter
2021-12-17 9:16 ` Steven Price
2021-12-17 9:28 ` Dan Carpenter
2021-12-17 9:48 ` Steven Price
2021-12-16 17:49 ` Alyssa Rosenzweig
2021-12-17 6:40 ` Dan Carpenter
2021-12-17 7:38 ` Tomeu Vizoso
2021-12-17 8:56 ` Steven Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e62a011-ef0a-fa04-664e-a70e5dd49cf2@arm.com \
--to=steven.price@arm.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=alyssa@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®