From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbcF2Iw1 (ORCPT ); Wed, 29 Jun 2016 04:52:27 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:57718 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbcF2IwY (ORCPT ); Wed, 29 Jun 2016 04:52:24 -0400 Subject: Re: [PATCH 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc To: Greg Kroah-Hartman References: <1467083835-37750-1-git-send-email-wangkefeng.wang@huawei.com> <1467083835-37750-3-git-send-email-wangkefeng.wang@huawei.com> CC: Jiri Slaby , , , Andy Shevchenko , , , From: Kefeng Wang Message-ID: <0e7153a4-9743-5a26-3212-42004fbf6930@huawei.com> Date: Wed, 29 Jun 2016 16:51:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1467083835-37750-3-git-send-email-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.57738C1F.016C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d7e6417f5b4cd14fd9138f4b7dddc554 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +cc linux-acpi@vger.kernel.org On 2016/6/28 11:17, Kefeng Wang wrote: > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > that it is not 16550 compatibal. > > Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out > and serial_in in ACPI. > > Signed-off-by: Kefeng Wang > --- > drivers/tty/serial/8250/8250_dw.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index 65f3da7..7571b0f 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -301,8 +301,11 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) > p->iotype = UPIO_MEM32; > p->regshift = 2; > p->serial_in = dw8250_serial_in32; > - /* So far none of there implement the Busy Functionality */ > - data->uart_16550_compatible = true; > + p->serial_out = dw8250_serial_out32; > + > + /* Hisilicon 8250 dw uart is not 16550 compatible */ > + if (!acpi_dev_found("HISI0031")) > + data->uart_16550_compatible = true; > } > > /* Platforms with iDMA */ > @@ -618,6 +621,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = { > { "APMC0D08", 0}, > { "AMD0020", 0 }, > { "AMDI0020", 0 }, > + { "HISI0031", 0 }, > { }, > }; > MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match); >