From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3E291CEACB for ; Tue, 5 Aug 2025 19:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754421536; cv=none; b=BDCX8O+hsM/USOtpI/8vDibEgRBC8Jo4dH85CXGaBzZbVIeq4WpUkL7PiOAaCzi9Vc+FoWopjYcOTRyPNGylImXEi1Y4t+g8oQjQnSg/u1eQxw8s6WFyNfscFe36rPimQofthlf1Uf+F4YpCb1PHDIdIGg4RuboYnJjPbEiGxq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754421536; c=relaxed/simple; bh=khGjDmYoi+SVIixaAvFiERs00u6nBzroY7eGFW5roXI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m4azCiruBG+XckwRWkio1gv8iu4a7VuHg2wdBnVRtVvouIZhpqC1xIYMEkZ0/xGjSLYaUrMUtwB6L8a8H9LF7IxnX/swGBWuJaZrGA8l6sRKoydjdo0a9AxOSPtMZ9qytxcJJWTJVStGe7+d+bADgVA4bMugNQ3WsA8+q+Dfvvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=ildi21gB; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="ildi21gB" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-615398dc162so10413697a12.3 for ; Tue, 05 Aug 2025 12:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1754421533; x=1755026333; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=140O1ncFTG+fzY5FppRujDaW5fNy7s7sdArHFrnvSdA=; b=ildi21gBaTCVHfyjhck7rIu82xWd/B92KfQss9RFmmMU8Otrqj0HHIxZ/6y61wudjM 6im+StLavEfnjjWmOTDtmDYvdZANYMxMSkwGQ9ovlAfcU+mK/N4bNqcazL95ks9VIFjf hwW0G1AaokOmET+Uzc4IHglz8+S6CHUJXE64WP53fquMenKmQM2hrIpjZYCkv1co58rJ j+V/RaKdo5mO4DN28MBEb8K4hPnmXQ2MjyNfpsLI/h+RtgfE/hVx+eFa5EQTSRDMY+yu 8SURZLIcMFS0x+P7MeYEt5TXjxWZVj+2ha03evTdWZPVXZqwOSdd+6fWFkSmQNqWkt5F aOZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754421533; x=1755026333; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=140O1ncFTG+fzY5FppRujDaW5fNy7s7sdArHFrnvSdA=; b=NrzjPbrmJ89fzyyML29CpPyFFsO5rUm9OmWC0AAYIbMjWxrRaTZhHoDvAt5exocaC7 Ulwhl+ZBeNOBYSZI7GEDIlq+2pkQtqWJoacscu+7wyqhdv0XN217SRmz6DFZf144CI1O 9oxqwFlwwKRVqPZsre449exK8oaB/AgdHuS9sncq7ehwV4DjLSNuxNOkcdgmD25Qqg0H c627TcIzBb0UFhOIoLeCHsaydLzaxttY2nWve/wEppEolnbcALXHZUu/YEHeCY09abci 4sW9f7mraaeO6qSq3JKU10OBReMmXoj6fswS4VzVKbamMvQdbXC39/O8Wwlsb+0Tm1tn uQZA== X-Forwarded-Encrypted: i=1; AJvYcCWY7toY28UAVXqtslLhHIgI/5KST+ZfXzo6ZtEzT4+So6FDqHGfu3eSCS9JYUx2WJf3afWy22lEQDOpGWM=@vger.kernel.org X-Gm-Message-State: AOJu0YwA6Ntn6ybgt9drNTEE1DPfykE8bTiWaTwfDRk/zOUBk/hOcM6Q LEpuT5tgAr5TlemDD5nwE4BXKctCKwTBxtOOThiEVs9pAlRmc6IaRWICBndZILdZ1m8= X-Gm-Gg: ASbGncsJ5zNeX+/rhYEx/NH+fVjPniusQKk05mJYzJd+0prfaXI6wwL1pNl6zxCuhAm mpA5z05KlXwpZLAJI/HFM/FoNcC6e457UqkFwk4V2LZQQnJdsrKXwGOBnBYvd/wTdAzRlFLMA8J QszG6gONDveJ7764krlW/6jWb7om7slFx6Z74aInPb4lXVxiagcPv4iGEjTA2z1AjQIU5fSxNOb kEgaLt8zLv3yUNEYWqASva0FDzKtt67vpHwSAt+LMJoEQIcxRTpk6T5PRdh4IGgUkPqU4T4/aYX yzMLGFViZ+fb9vLw33pPESlD6bhfoanIlaFhIl5Tehj0ppRFULe61rs+tF2PiUCVe7bXTf8fDkm 6+O5mAjwXGkshnkjHUxAPX3ix+TEGb0U= X-Google-Smtp-Source: AGHT+IEzXYwKjDntoDBqUMYR9EV4V8wSDk+SRkS8ZRK9bW7nJsA/RiJNAmx7QhFIkvnw2H395/NCDA== X-Received: by 2002:a17:907:1c84:b0:ae3:f3c1:a5dd with SMTP id a640c23a62f3a-af99050715dmr11853966b.61.1754421532805; Tue, 05 Aug 2025 12:18:52 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a078a11sm974656666b.7.2025.08.05.12.18.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 12:18:52 -0700 (PDT) Message-ID: <0e718be7-32df-4fc1-af49-8dfd42143d55@tuxon.dev> Date: Tue, 5 Aug 2025 22:18:51 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] clk: renesas: r9a07g043: Add MSTOP for RZ/G2UL To: Geert Uytterhoeven Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20250704134328.3614317-1-claudiu.beznea.uj@bp.renesas.com> <20250704134328.3614317-4-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Geert, On 04.08.2025 13:18, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Fri, 4 Jul 2025 at 15:43, Claudiu wrote: >> From: Claudiu Beznea >> >> Add MSTOP configuration for all the module clocks on the RZ/G2UL >> based SoCs (RZ/G2UL, RZ/V2L, RZ/Five). >> >> Signed-off-by: Claudiu Beznea > > Thanks for your patch! > >> --- a/drivers/clk/renesas/r9a07g043-cpg.c >> +++ b/drivers/clk/renesas/r9a07g043-cpg.c >> DEF_MOD("canfd", R9A07G043_CANFD_PCLK, R9A07G043_CLK_P0, >> - 0x594, 0, 0), >> + 0x594, 0, MSTOP(BUS_MCPU2, BIT(9))), >> DEF_MOD("gpio", R9A07G043_GPIO_HCLK, R9A07G043_OSCCLK, >> 0x598, 0, 0), > > MSTOP(BUS_PERI_CPU, BIT(6))? Yes, this should be here. I'll add it in the next version. Thank you for your review, Claudiu > >> DEF_MOD("adc_adclk", R9A07G043_ADC_ADCLK, R9A07G043_CLK_TSU, >> - 0x5a8, 0, 0), >> + 0x5a8, 0, MSTOP(BUS_MCPU2, BIT(14))), > > The rest LGTM. > > Gr{oetje,eeting}s, > > Geert >