mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Chen Ni <nichen@iscas.ac.cn>,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	niravkumarlaxmidas.rabara@altera.com, piotrs@cadence.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: cadence: Fix error check for dma_alloc_coherent() in cadence_nand_init()
Date: Wed, 25 Feb 2026 16:00:08 +0530	[thread overview]
Message-ID: <0e75b0df-2134-4698-84bb-425b6ac80108@oracle.com> (raw)
In-Reply-To: <20260209075618.1683125-1-nichen@iscas.ac.cn>



On 2/9/2026 1:26 PM, Chen Ni wrote:
> Fix wrong variable used for error checking after dma_alloc_coherent()
> call. The function checks cdns_ctrl->dma_cdma_desc instead of
> cdns_ctrl->cdma_desc, which could lead to incorrect error handling.
> 
> Fixes: ec4ba01e894d ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
> Signed-off-by: Chen Ni<nichen@iscas.ac.cn>
> ---
>   drivers/mtd/nand/raw/cadence-nand-controller.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
> index 99135ec23010..d53b35a8b3cb 100644
> --- a/drivers/mtd/nand/raw/cadence-nand-controller.c
> +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
> @@ -3133,7 +3133,7 @@ static int cadence_nand_init(struct cdns_nand_ctrl *cdns_ctrl)
>   						  sizeof(*cdns_ctrl->cdma_desc),
>   						  &cdns_ctrl->dma_cdma_desc,
>   						  GFP_KERNEL);
> -	if (!cdns_ctrl->dma_cdma_desc)
> +	if (!cdns_ctrl->cdma_desc)
>   		return -ENOMEM;

LGTM,

Reviewed-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Thanks,
Alok

  reply	other threads:[~2026-02-25 10:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09  7:56 Chen Ni
2026-02-25 10:30 ` ALOK TIWARI [this message]
2026-02-25 16:49 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e75b0df-2134-4698-84bb-425b6ac80108@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nichen@iscas.ac.cn \
    --cc=niravkumarlaxmidas.rabara@altera.com \
    --cc=piotrs@cadence.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®