Re: [PATCH 1/2] dt-bindings: phy: Add YAML schemas for Intel Combo phy

[Dilip Kota <eswara.kota@linux.intel.com>]

On 1/8/2020 10:18 PM, Rob Herring wrote:
> On Fri, Dec 20, 2019 at 03:28:27PM +0800, Dilip Kota wrote:
>> Combo phy subsystem provides PHY support to number of
>> controllers, viz. PCIe, SATA and EMAC.
>> Adding YAML schemas for the same.
>>
>> Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
>> ---
>>   .../devicetree/bindings/phy/intel,combo-phy.yaml   | 147 +++++++++++++++++++++
>>   1 file changed, 147 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml b/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
>> new file mode 100644
>> index 000000000000..fc9cbad9dd88
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
>> @@ -0,0 +1,147 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/intel,combo-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Intel Combo phy Subsystem
>> +
>> +maintainers:
>> +  - Dilip Kota <eswara.kota@linux.intel.com>
>> +
>> +description: |
>> +  Intel combo phy subsystem supports PHYs for PCIe, EMAC and SATA
>> +  controllers. A single combo phy provides two PHY instances.
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "^combophy@[0-9]+$"
>> +
>> +  compatible:
>> +    items:
>> +      - const: intel,combo-phy
>> +      - const: simple-bus
> This will cause the schema to be applied to every 'simple-bus'. You need
> a custom 'select' to prevent that. There's several examples in the tree.

Ok, i will add as below:

# We need a select here so we don't match all nodes with 'simple-bus'
select:
   properties:
     compatible:
       contains:
         const: intel,combo-phy
   required:
     - compatible

>
> Though I'm not sure you need child nodes here.
>
>> +
>> +  cell-index:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Index of Combo phy hardware instance.
> Drop this. Not used for FDT.
Ok, I will remove this and use the 'aliases' to get the hardware instance.
>
>> +
>> +  resets:
>> +    maxItems: 2
>> +
>> +  reset-names:
>> +    items:
>> +      - const: phy
>> +      - const: core
>> +
>> +  intel,syscfg:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: Chip configuration registers handle
>> +
>> +  intel,hsio:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: HSIO registers handle
>> +
>> +  intel,bid:
>> +    description: Index of HSIO bus
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/uint32
>> +      - minimum: 0
>> +      - maximum: 1
> If this is related to intel,hsio, just make it an args cell for
> intel,hsio.
No. Actually, this is specific to the combophy instance on the HSIO bus.
I see , this can be removed and value can be derived from the hardware 
instance value mentioned through 'aliases'
>> +
>> +  intel,cap-pcie-only:
>> +    description: |
>> +      This flag specifies capability of the combo phy.
>> +      If it is set, combo phy has only PCIe capability.
>> +      Else it has PCIe, XPCS and SATA PHY capabilities.
>> +    type: boolean
>> +
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    const: 1
>> +
>> +  ranges: true
>> +
>> +patternProperties:
>> +  "^cb[0-9]phy@[0-9]+$":
>> +    type: object
>> +
>> +    properties:
>> +      compatible:
>> +        const: intel,phydev
>> +
>> +      "#phy-cells":
>> +        const: 0
>> +
>> +      reg:
>> +        description: Offset and size of pcie phy control registers
>> +
>> +      intel,phy-mode:
>> +        description: |
>> +          Configure the mode of the PHY.
>> +            0 - PCIe
>> +            1 - xpcs
>> +            2 - sata
> PHY mode is normally a cell in the client's phys property. There's
> already common defines for this.
Sure, will update the code to use phys property and remove this entry,
>
>> +        allOf:
>> +          - $ref: /schemas/types.yaml#/definitions/uint32
>> +          - minimum: 0
>> +          - maximum: 2
>> +
>> +      clocks:
>> +        description: |
>> +          List of phandle and clock specifier pairs as listed
>> +          in clock-names property. Configure the clocks according
>> +          to the PHY mode.
>> +
>> +      resets:
>> +        description: |
>> +          reset handle according to the PHY mode.
>> +          See ../reset/reset.txt for details.
>> +
>> +    required:
>> +      - compatible
>> +      - reg
>> +      - "#phy-cells"
>> +      - clocks
>> +      - intel,phy-mode
>> +
>> +required:
>> +  - compatible
>> +  - cell-index
>> +  - "#address-cells"
>> +  - "#size-cells"
>> +  - ranges
>> +  - intel,syscfg
>> +  - intel,hsio
>> +  - intel,bid
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    combophy@0 {
>> +        compatible = "intel,combo-phy", "simple-bus";
>> +        cell-index = <0>;
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +        ranges;
>> +        resets = <&rcu0 0x50 6>,
>> +        	 <&rcu0 0x50 17>;
>> +        reset-names = "phy", "core";
>> +        intel,syscfg = <&sysconf>;
>> +        intel,hsio = <&hsiol>;
>> +        intel,bid = <0>;
>> +
>> +        cb0phy0:cb0phy@0 {
>> +            compatible = "intel,phydev";
>> +            #phy-cells = <0>;
>> +            reg = <0xd0a40000 0x1000>;
>> +            clocks = <&cgu0 1>;
>> +            resets = <&rcu0 0x50 23>;
>> +            intel,phy-mode = <0>;
>> +        };
> If you only have 1 child, then you don't need a child node here. Is this
> example complete?
2 children are required, as it is an example i just added one.
I will add the other child too.

Thanks for reviewing and giving the inputs.


Regards,
Dilip

>> +    };
>> +
>> +
>> -- 
>> 2.11.0
>>