From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31FCCC7EE2C for ; Mon, 5 Jun 2023 13:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234203AbjFENqV (ORCPT ); Mon, 5 Jun 2023 09:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231769AbjFENqT (ORCPT ); Mon, 5 Jun 2023 09:46:19 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32542F9 for ; Mon, 5 Jun 2023 06:46:15 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3f6042d610fso48211355e9.1 for ; Mon, 05 Jun 2023 06:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1685972773; x=1688564773; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rYKK5WNMfEjOGjyNV4BV3FvblimxrGOB2o0YYjGZMoc=; b=o14Lr3M7upHuE04It/xjCa/cGiFZydRy2hUwTK9XlH2YrDGpqVeV30TZrLGhiki0vJ yGrI8dACugq0IEvTWfhms4gs7Y+7zu3vZuYNML6zZKk9F4bMY1ZYjnJfxp15iqvO1Ast /pH9IYZGG2eW6ljMvGK8/1MjKS9hMqGeKd9dXX8BiPb30VjeWHO4EAaZd64KNX18Hvzi FL5jPdrgXYRRrkoAWgL7GFtjIbkZ8b6w3kqgu+LvsMoOM+s3VtjAEYaGM8ALMdzdy+e9 lYSsqb4b83Eo6wG8Y/ladavWs1TvECsSxmVly/haTUzpQuFU/8bP1AtRUMoIHunMjAOl kmcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685972773; x=1688564773; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rYKK5WNMfEjOGjyNV4BV3FvblimxrGOB2o0YYjGZMoc=; b=Vws6aUxglTIuNyr7dObbr6YHTsXWMJbFZr1XnSRKpkD6mj3KAuD25wT5DqI9vvKz+b jiLtRMh8wpKcQT998TN2ks5C2TG/8eRFWQYtjxBWMPJqq3cgzKMnv55VRSspTFnDGUfi JIYBErqkCvafDMK425qoqk9L4huhnp5xTYAt98Uyt5e9r9i3JkkKfo58bQRM05W766LW r5XoaoI02KzCQFRX5KvqWfXksmXSzTJ3xX32/R609n863b4NUk1jD4y/CN9rv2viUTOK vnibaATxGJw6rVEZ8xmNNBfsezfNciPfHo5yYMobW487F5UFyPhba9qXiR8QAKjFoIv9 dNkg== X-Gm-Message-State: AC+VfDzHSe7symd+ye1l6cAHwFytX/AQGy8jMMTvxMH4E9Rrk9Dk28xD 2gIN20N+8SFgYndfbzKz8YDWvg== X-Google-Smtp-Source: ACHHUZ6pe5WzdC0oeZHm5ttRdAIOIatHBO9NbMz+Wi/TXtcIHPM0H3CJ2RQWxyznNcTYqcUoUr/Bgg== X-Received: by 2002:a1c:f70a:0:b0:3f6:da2:bc86 with SMTP id v10-20020a1cf70a000000b003f60da2bc86mr7668207wmh.7.1685972773675; Mon, 05 Jun 2023 06:46:13 -0700 (PDT) Received: from [192.168.1.172] (158.22.5.93.rev.sfr.net. [93.5.22.158]) by smtp.gmail.com with ESMTPSA id c11-20020a05600c0acb00b003f72d7dc66esm7682965wmr.13.2023.06.05.06.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 06:46:13 -0700 (PDT) Message-ID: <0e7cc4cf-68da-207d-03b5-f9bd065f7940@baylibre.com> Date: Mon, 5 Jun 2023 15:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4] mmc: mtk-sd: reduce CIT for better performance Content-Language: en-US To: Wenbin Mei , Ulf Hansson Cc: Chaotian Jing , Matthias Brugger , AngeloGioacchino Del Regno , Adrian Hunter , Ritesh Harjani , Asutosh Das , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230605121442.23622-1-wenbin.mei@mediatek.com> From: Alexandre Mergnat In-Reply-To: <20230605121442.23622-1-wenbin.mei@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2023 14:14, Wenbin Mei wrote: > CQHCI_SSC1 indicates to CQE the polling period to use when using periodic > SEND_QUEUE_STATUS(CMD13) polling. > Since MSDC CQE uses msdc_hclk as ITCFVAL, so driver should use hclk > frequency to get the actual time. > The default value 0x1000 that corresponds to 150us for MediaTek SoCs, let's > decrease it to 0x40 that corresponds to 2.35us, which can improve the > performance of some eMMC devices. Hi, - Can you add the version change log and the link to the previous patch version (at least) please ? - On which board(s) did you test this patch please ? -- Regards, Alexandre