mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Peter Wang (王信友)" <peter.wang@mediatek.com>
Subject: Re: [PATCH 1/2] ufs: core: Add quriks for VCC ramp-up delay
Date: Fri, 6 Mar 2026 00:19:23 +0000	[thread overview]
Message-ID: <0e812b2b96603f69467b57ae6e9836ef8b4bd1ff.camel@mediatek.com> (raw)
In-Reply-To: <fd1fb573-6d02-433e-a74a-1a015c64e3be@acm.org>

On Thu, 2026-03-05 at 06:24 -0600, Bart Van Assche wrote:
> On 3/5/26 2:29 AM, ed.tsai@mediatek.com wrote:
> > +     /*
> > +      * On platforms with a slow VCC ramp-up, a delay is needed
> > after
> > +      * turning on VCC to ensure the voltage is stable before the
> > +      * reference clock is enabled.
> > +      */
> > +     if (hba->quirks & UFSHCD_QUIRK_VCC_ON_DELAY && !ret && vcc_on
> > &&
> > +         hba->vreg_info.vcc && !hba->vreg_info.vcc->always_on)
> > +             usleep_range(1000, 1100);
> 
> Since the value of the delay is platform-dependent, has it been
> considered to introduce a new vendor operation (vop)?
> 
> Thanks,
> 
> Bart.

A vop does feel a bit heavyweight for a simple sleep. How about we add
a new configurable variable, similar to the approach used for the VCC
off delay?

Best,

Ed Tsai

  reply	other threads:[~2026-03-06  0:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05  8:29 [PATCH 0/2] ufs: add delay for VCC ramp-up stability ed.tsai
2026-03-05  8:29 ` [PATCH 1/2] ufs: core: Add quriks for VCC ramp-up delay ed.tsai
2026-03-05 12:24   ` Bart Van Assche
2026-03-06  0:19     ` Ed Tsai (蔡宗軒) [this message]
2026-03-06  2:15       ` Bart Van Assche
2026-03-06  2:16   ` Bart Van Assche
2026-03-05  8:29 ` [PATCH 2/2] ufs: host: mediatek: Add VCC on delay for stability ed.tsai
2026-03-05 12:20   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e812b2b96603f69467b57ae6e9836ef8b4bd1ff.camel@mediatek.com \
    --to=ed.tsai@mediatek.com \
    --cc=Chun-hung.Wu@mediatek.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®