From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753894AbdGNPqT (ORCPT ); Fri, 14 Jul 2017 11:46:19 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:54521 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753124AbdGNPqR (ORCPT ); Fri, 14 Jul 2017 11:46:17 -0400 From: Jose Abreu To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jose Abreu , Carlos Palminha , Alexey Brodkin , Daniel Vetter , Dave Airlie Subject: [PATCH] drm: arcpgu: Fix mmap() callback Date: Fri, 14 Jul 2017 16:46:06 +0100 Message-Id: <0e8408944a0ed4cb7463f4eccf2ab4b79662d68b.1491929268.git.joabreu@synopsys.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that ARC properly supports DMA mmapping we can use the standard CMA helper to map dumb buffers. This makes ARC PGU works with standard DRM consumer applications like, for example, mpv via DRM. This fixes the use of dumb buffers. Signed-off-by: Jose Abreu Fixes: 0c4250e7b15e ("drm: Add support of ARC PGU display controller") Cc: Carlos Palminha Cc: Alexey Brodkin Cc: Daniel Vetter Cc: Dave Airlie --- drivers/gpu/drm/arc/arcpgu_drv.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c index 1926b20..890bc87 100644 --- a/drivers/gpu/drm/arc/arcpgu_drv.c +++ b/drivers/gpu/drm/arc/arcpgu_drv.c @@ -48,18 +48,6 @@ static void arcpgu_setup_mode_config(struct drm_device *drm) drm->mode_config.funcs = &arcpgu_drm_modecfg_funcs; } -static int arcpgu_gem_mmap(struct file *filp, struct vm_area_struct *vma) -{ - int ret; - - ret = drm_gem_mmap(filp, vma); - if (ret) - return ret; - - vma->vm_page_prot = pgprot_noncached(vm_get_page_prot(vma->vm_flags)); - return 0; -} - static const struct file_operations arcpgu_drm_ops = { .owner = THIS_MODULE, .open = drm_open, @@ -69,7 +57,7 @@ static int arcpgu_gem_mmap(struct file *filp, struct vm_area_struct *vma) .poll = drm_poll, .read = drm_read, .llseek = no_llseek, - .mmap = arcpgu_gem_mmap, + .mmap = drm_gem_cma_mmap, }; static void arcpgu_lastclose(struct drm_device *drm) -- 1.9.1