Re: [PATCH v2 1/1] kbuild: record real-prereqs in .cmd files

[Luis Augenstein <luis.augenstein@tngtech.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1791 bytes --]

On 10/7/26 16:46, Nicolas Schier wrote:
>> Record $(real-prereqs), the non-phony prerequisites of the target, in a
>> new metadata field:
>>
>>      make_prereqs_<target> := <prerequisites>
>>
>> Write the field from both cmd_and_savecmd and cmd_and_fixdep.
>>
>> Update scripts/make_fit.py to read only savedcmd_* instead of parsing the
>> complete .cmd file.
> 
> This sounds like a good thing; but I can't find that in the diff.

It's the first section in the diff in scripts/Kbuild.include.
The original sentence might have been a bit unclear though.
$(cmd-prereqs) is the new variable that is actually used by
cmd_and_savecmd and cmd_and_fixdep. However, since $(cmd-prereqs) is
just $(real-prereqs) with $(deps_) filtered out, I omitted this
intermediate step in the description. I will rephrase it in v3 to make
it more clear.

> Why do you defer the actual implementation in the SBOM scripts?  From my
> point of view, the introduction of 'make_prereqs_<target>' looks good
> and I don't see a reason for waiting with the corresponding SBOM
> implementation.

I thought it would be a sensible boundary to first change Kbuild and
then separately update the SBOM tool to use the new information the
.cmd files offer. Also, when I posted this series, I simply didn't
have the SBOM patches finished yet. By now they are ready for review
as well, so I will include them in v3 of this series.

thanks, Luis

-- 
Luis Augenstein * luis.augenstein@tngtech.com * +4915225275761
TNG Technology Consulting GmbH, Beta-Str. 13, 85774 Unterföhring
Geschäftsführer: Dr. Robert Dahlke, Thomas Endres, Moritz Prinz
Aufsichtsratsvorsitzender: Henrik Klagges
Sitz: Unterföhring * Registergericht: Amtsgericht München * 
Handelsregisternummer: HRB 135082


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]