From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error
Date: Wed, 30 Apr 2014 09:21:52 +0000 [thread overview]
Message-ID: <0e8d4a56dbcf440797d5057d22b255b3@BY2PR03MB505.namprd03.prod.outlook.com> (raw)
In-Reply-To: <4308079.So6q7GrfYB@wuerfel>
> Subject: [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error
>
> 49101a25acd69c "ASoC: cq93vc: Remove the set_cache_io() entirely from
> ASoC probe" introduced the cq93vc_get_regmap function that has an
> obvious build error referring to the 'codec' variable that is not
> declared anywhere"
>
> sound/soc/codecs/cq93vc.c: In function 'cq93vc_get_regmap':
> sound/soc/codecs/cq93vc.c:157:34: error: 'codec' undeclared (first use in this
> function)
> struct davinci_vc *davinci_vc = codec->dev->platform_data;
> ^
>
> This changes the code to compile again, presumably in the way it was
> intended. Not tested.
>
Reviewed-by: Xiubo Li <Li.Xiubo@freescale.com>
Thanks,
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Xiubo Li <Li.Xiubo@freescale.com>
>
> diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
> index 5ee48c8..537327c 100644
> --- a/sound/soc/codecs/cq93vc.c
> +++ b/sound/soc/codecs/cq93vc.c
> @@ -154,7 +154,7 @@ static int cq93vc_remove(struct snd_soc_codec *codec)
>
> static struct regmap *cq93vc_get_regmap(struct device *dev)
> {
> - struct davinci_vc *davinci_vc = codec->dev->platform_data;
> + struct davinci_vc *davinci_vc = dev->platform_data;
>
> return davinci_vc->regmap;
> }
next prev parent reply other threads:[~2014-04-30 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 9:06 Arnd Bergmann
2014-04-30 9:21 ` Li.Xiubo [this message]
2014-05-01 1:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e8d4a56dbcf440797d5057d22b255b3@BY2PR03MB505.namprd03.prod.outlook.com \
--to=li.xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®